Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MonitorHandle PartialEq and Hash on iOS #4013

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Nov 28, 2024

See bevyengine/bevy#16541, we were comparing the pointer addresses of MonitorHandle (which changes every time a new one is created) instead of UIScreen (which is more stable).

TODO:

  • Actually test this.
    • Tested on the iOS simulator (with a single screen) and Mac Catalyst (with two monitors).
  • Make a test for it.
  • Add an entry to the changelog.

@madsmtm madsmtm added B - bug Dang, that shouldn't have happened DS - ios labels Nov 28, 2024
@madsmtm madsmtm force-pushed the madsmtm/monitor-comparisons branch 2 times, most recently from 69c21f3 to 88ce1eb Compare December 3, 2024 12:47
@madsmtm madsmtm force-pushed the madsmtm/monitor-comparisons branch from 88ce1eb to fb0dc36 Compare December 3, 2024 12:55
@madsmtm madsmtm marked this pull request as ready for review December 3, 2024 13:21
@madsmtm madsmtm modified the milestones: Version 0.31.0, Version 0.30.6 Dec 3, 2024
@madsmtm madsmtm merged commit 4a8b659 into master Dec 3, 2024
58 checks passed
@madsmtm madsmtm deleted the madsmtm/monitor-comparisons branch December 3, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened DS - ios
Development

Successfully merging this pull request may close these issues.

2 participants