api: make OwnedDisplayHandle wrap an opaque type #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@notgull we can probably leak the C types(wl_display/x11 connection) when shutting down the event loop if they still have uses? |
notgull
requested changes
Nov 3, 2024
kchibisov
force-pushed
the
kchibisov/arc-display-handle
branch
from
fb21429 to
3790790
Compare
This will help in case we want to linger the event loop during drop to prevent use after free in the consumers code.
kchibisov
force-pushed
the
kchibisov/arc-display-handle
branch
from
3790790 to
b5b7ffd
Compare
kchibisov
requested review from
jackpot51,
daxpedda,
madsmtm and
MarijnS95
as code owners
notgull
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help in case we want to linger the event loop during drop
to prevent use after free in the consumers code.f
--
Depends on #3980