Add support and CI tests for BSDs #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
reviewed
Dec 27, 2022
|
I was thinking the same thing, but thought that could be a problem for Android if/when that's added (#44). And I guess Haiku is Annoying that Rust doesn't have a way to define a config option once that could be used everywhere for less repetition. |
|
We could use |
|
Updated to It's using |
notgull
reviewed
Dec 27, 2022
notgull
reviewed
Dec 27, 2022
notgull
reviewed
Dec 28, 2022
i509VCB
reviewed
Jan 1, 2023
This adds a fallback using `shm_open`/`shm_unlink` for platforms where `memfd_create` doesn't exist. This seems to be how this is normally handled, though it's a bit ugly. This also builds the wayland/x11 code for NetBSD/OpenBSD/DragonFlyBSD. Add CI builds for FreeBSD and NetBSD. We would need some kind of virtualisation though to actually run tests on such targets. I've tested the `shm_open` logic on Linux, but haven't run it on any BSDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a fallback using
shm_open/shm_unlinkfor platforms wherememfd_createdoesn't exist. This seems to be how this is normally handled, though it's a bit ugly.This also builds the wayland/x11 code for NetBSD/OpenBSD/DragonFlyBSD.
Add CI builds for FreeBSD and NetBSD. We would need some kind of virtualisation though to actually run tests on such targets.
I've tested the
shm_openlogic on Linux, but haven't run it on any BSDs.