Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for potentially useful features in future Rust versions #114

Open
notgull opened this issue May 31, 2023 · 2 comments
Open

Comments

@notgull
Copy link
Member

notgull commented May 31, 2023

As of the time of writing, the MSRV for softbuffer is 1.64.0. As far as I can tell there is no MSRV policy, but the informal rule seems to be that the limit is Rust versions released up to seven months ago. This issue keeps track of features that may be useful to softbuffer, but cannot be used yet because we don't have the required Rust version.

  • Nightly
    • Fallible allocation could be worked into the error enum to provide a condition for low-memory systems.
    • We implement some parts as what's essentially a try block, but as a closure that is immediately called. Example. It would be nice to replace those cases with a simple try block.
    • We use a Box to wrap SurfaceDispatch in order to keep the type size predictable. However, for low memory systems we could use the allocator_api feature to provide a custom allocator to reduce allocations.

Feel free to add more that I've missed.

@ids1024
Copy link
Member

ids1024 commented May 31, 2023

As of the time of writing, the MSRV for softbuffer is 1.64.0. As far as I can tell there is no MSRV policy, but the informal rule seems to be that the limit is Rust versions released up to seven months ago.

The current requirement is based on what raw-window-handle requires, and matches what winit targets. I think it generally makes sense for softbuffer to not have a higher Rust MSRV than winit, anyway.

(Is there any particular MSRV policy for winit/glutin/raw-window-handle either? If any of these projects had an MSRV policy, it would make sense for them to be in sync.)

But it's good to track Rust features like this anyway.

@madsmtm
Copy link
Member

madsmtm commented Jun 1, 2023

See rust-windowing/winit#1075 for previous discussion on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants