rustup-init leaves user with colored terminal #2590

Vbbab · 2020-12-01T00:56:46Z

(If this doesn't belong here, please tell me which repo to move it to, thanks!)

Problem

rustup's setup script, rustup-init, leaves the user with a colored terminal when exiting interrupted.

Steps

Execute rustup-init
At the first prompt, interrupt by Ctrl-C
User's shell is now red.

Possible Solution(s)
Check the interrupted-exit code maybe? Make sure that the color is reset before exiting (Since ^C is displayed in red)

Notes

OS: Win 10 (1909)
Output of rustup --version: rustup 1.23.0 (00924c9ba 2020-11-27)
Output of rustup-init --version: rustup-init 1.22.1 (b01adbbc3 2020-07-08)
Output of rustup show:

Default host: x86_64-pc-windows-msvc
rustup home:  C:\Users\kangj\.rustup

installed toolchains
--------------------

stable-x86_64-pc-windows-msvc
nightly-x86_64-pc-windows-msvc (default)

active toolchain
----------------

nightly-x86_64-pc-windows-msvc (default)
rustc 1.48.0-nightly (6af1bdda5 2020-09-15)

The text was updated successfully, but these errors were encountered:

kinnison · 2020-12-01T08:15:32Z

Thank you for your report, I shall try and reproduce this tonight. If anyone else reads this and knows what might be going on, please comment on the issue, I'm not a Windows developer by default.

toothbrush7777777 · 2020-12-07T11:49:52Z

I've run into this before. It happens because conhost doesn't reset the terminal colours after a program is terminated.
I think bash and most other terminals & shells resets the colour automatically.

kinnison · 2020-12-08T14:19:19Z

What's odd is that there's no red in the rustup output at that point. So I wonder what we've done to the terminal that is causing that.

Vbbab · 2020-12-10T15:44:20Z

Perhaps the Interrupt is colored (^C)?

Vbbab · 2020-12-10T15:45:10Z

Oh and it appears that the bug only reproduces if you wait a few seconds at the first prompt. In that case the interrupt is red.

Waiting up to 4 seconds before interrupting will actually show the beginning of an error, which could be why it's red...

kinnison · 2020-12-10T20:13:48Z

What error is it showing at that point? can you attach a screenshot?

Vbbab · 2020-12-10T20:15:35Z

If I interrupt it at exactly 4 seconds, this error shows up, but is blank:

kinnison · 2020-12-10T20:19:23Z

Oh interesting, I wonder if the control+C managed to give it some input before it killed it.

Vbbab · 2020-12-10T20:36:27Z

but if I interrupt at different time intervals, things happen:

Immediately: Regular white ^C, user shell is normal
At 4 secs: error, red ^C, user shell is red
Between 1-4 secs, and more than 4 secs: no error, red ^C, user shell is red

kinnison · 2020-12-10T20:38:22Z

That is extremely odd.

Vbbab · 2020-12-10T20:39:16Z

Could this be a bug with some sort of input-handling loop? Or maybe rustup-init is loading something within the initial 4 secs?

kinnison · 2020-12-10T20:40:44Z

I guess possibly. I'm not entirely sure how the input loop behaves on Windows.

Vbbab · 2020-12-10T20:44:05Z

OK... Is there any way that I can see rustup-init's code? (Or is that closed-source?) All I see on this repo is a rustup-init.sh

kinnison · 2020-12-10T20:56:13Z

the src/ tree is rustup and rustup-init - it's all open source. the code in question will be in src/cli/self_update.rs most likely

Vbbab · 2020-12-10T22:47:14Z

OK, thanks!

kinnison · 2021-01-09T11:23:48Z

I'm not able to reproduce this, which is also odd. Are you able to investigate at all @Vbbab ?

Vbbab · 2021-01-09T22:12:47Z

Hmm, I could try, but I'm not really familiar with Rust, sorry...

Perhaps someone else with Windows and experience with Rust?

chansuke · 2021-01-11T11:32:01Z

I have a WIndows machine and would like to try to reproduce the error tomorrow.

kinnison · 2021-01-12T19:42:21Z

If you can reliably reproduce this then we stand a chance of diagnosing it, yes please @chansuke

chansuke · 2021-01-25T01:19:51Z

I tried to reproduce the error (rustup 1.23.1 (3df2264a9 2020-11-30)) but couldn't succeed...

Vbbab · 2021-01-25T06:42:01Z

An update: There's some error message on my end now. Very rare chance of this actually occurring.

The regular way is by hitting ctrl-c as soon as you arrive at the initial prompt, at which point a red ^C would display and leave your shell red.

Oh interesting, I wonder if the control+C managed to give it some input before it killed it.

I do believe so. Take a look:

Vbbab · 2021-01-25T06:42:42Z

Another screenshot of repro:

toothbrush7777777 · 2021-01-25T13:43:17Z

I think it was easier to reproduce with certain anti-viruses. I can't remember which but I think McAfee was one.

chansuke · 2021-01-27T00:49:54Z

@toothbrush7777777 Ah...thank you for the detailed information!! I will take a look again.

guilt · 2021-02-16T23:16:59Z

I think you'd typically have to set the reset sequence (explictly print) on die.

rustup/src/cli/log.rs

Line 33 in 90c8401

let _ = writeln!(t);

Like, at the end of these kinda functions + general execution, good to add a
let _ = t.reset();

I mean, they could always die without reset-ting (and is a common issue with most commands in Unix as well, nothing new). They usually can handle that atexit / signal handler.

Vbbab · 2021-02-17T03:50:20Z

BTW, another way to repro:

Navigate to the directory of rustup-init.
Type rustup-init, but don't hit enter.
Now, follow enter key immediately with ctrl - c.
Repeat until the bug is produced.

guilt · 2021-02-17T04:00:59Z

We need to check where all this can happen; What if there's a fault when printing something, or SIGKILL; If this is a signal handler, the at_exit patch I've posted can be easily re-written; Will figure out how to test it.

My question to all is that is at_exit even a standard at this point? beta/stable compilers don't expose it.

kinnison · 2021-02-20T16:11:50Z

I don't think we're going to get to a stable-compatible solution to this problem in the 1.24.0 cycle so I'm going to defer this particular piece of work for 1.25.0 - if we fix it before 1.24.0 is branched then that's great, but I'm not going to hold up the release for it.

I think we're approaching an idea of the fix, but with the need for nightly right now, we're not able to use it yet.

workingjubilee · 2021-04-29T20:30:31Z

@rustbot label: +O-windows

Vbbab added the bug label Dec 1, 2020

kinnison self-assigned this Dec 1, 2020

kinnison added this to the 1.24.0 milestone Dec 1, 2020

kinnison removed their assignment Jan 9, 2021

guilt linked a pull request Feb 17, 2021 that will close this issue

Add on_log_quit. #2669

Draft

kinnison added the help wanted label Feb 20, 2021

kinnison modified the milestones: 1.24.0, 1.25.0 Feb 20, 2021

rustbot added the O-windows Windows related label Apr 29, 2021

rami3l modified the milestones: 1.25.0, 1.28.0 Jan 17, 2024

djc mentioned this issue Aug 19, 2024

1.28.0 release planning #3998

Open

rami3l modified the milestones: 1.28.0, 1.28.1 Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustup-init leaves user with colored terminal #2590

rustup-init leaves user with colored terminal #2590

Vbbab commented Dec 1, 2020

kinnison commented Dec 1, 2020

toothbrush7777777 commented Dec 7, 2020 •

edited

Loading

kinnison commented Dec 8, 2020

Vbbab commented Dec 10, 2020

Vbbab commented Dec 10, 2020 •

edited

Loading

kinnison commented Dec 10, 2020

Vbbab commented Dec 10, 2020

kinnison commented Dec 10, 2020

Vbbab commented Dec 10, 2020

kinnison commented Dec 10, 2020

Vbbab commented Dec 10, 2020 •

edited

Loading

kinnison commented Dec 10, 2020

Vbbab commented Dec 10, 2020

kinnison commented Dec 10, 2020

Vbbab commented Dec 10, 2020

kinnison commented Jan 9, 2021

Vbbab commented Jan 9, 2021

chansuke commented Jan 11, 2021

kinnison commented Jan 12, 2021

chansuke commented Jan 25, 2021 •

edited

Loading

Vbbab commented Jan 25, 2021

Vbbab commented Jan 25, 2021 •

edited

Loading

toothbrush7777777 commented Jan 25, 2021

chansuke commented Jan 27, 2021

guilt commented Feb 16, 2021 •

edited

Loading

Vbbab commented Feb 17, 2021

guilt commented Feb 17, 2021

kinnison commented Feb 20, 2021

workingjubilee commented Apr 29, 2021

rustup-init leaves user with colored terminal #2590

rustup-init leaves user with colored terminal #2590

Comments

Vbbab commented Dec 1, 2020

kinnison commented Dec 1, 2020

toothbrush7777777 commented Dec 7, 2020 • edited Loading

kinnison commented Dec 8, 2020

Vbbab commented Dec 10, 2020

Vbbab commented Dec 10, 2020 • edited Loading

kinnison commented Dec 10, 2020

Vbbab commented Dec 10, 2020

kinnison commented Dec 10, 2020

Vbbab commented Dec 10, 2020

kinnison commented Dec 10, 2020

Vbbab commented Dec 10, 2020 • edited Loading

kinnison commented Dec 10, 2020

Vbbab commented Dec 10, 2020

kinnison commented Dec 10, 2020

Vbbab commented Dec 10, 2020

kinnison commented Jan 9, 2021

Vbbab commented Jan 9, 2021

chansuke commented Jan 11, 2021

kinnison commented Jan 12, 2021

chansuke commented Jan 25, 2021 • edited Loading

Vbbab commented Jan 25, 2021

Vbbab commented Jan 25, 2021 • edited Loading

toothbrush7777777 commented Jan 25, 2021

chansuke commented Jan 27, 2021

guilt commented Feb 16, 2021 • edited Loading

Vbbab commented Feb 17, 2021

guilt commented Feb 17, 2021

kinnison commented Feb 20, 2021

workingjubilee commented Apr 29, 2021

toothbrush7777777 commented Dec 7, 2020 •

edited

Loading

Vbbab commented Dec 10, 2020 •

edited

Loading

Vbbab commented Dec 10, 2020 •

edited

Loading

chansuke commented Jan 25, 2021 •

edited

Loading

Vbbab commented Jan 25, 2021 •

edited

Loading

guilt commented Feb 16, 2021 •

edited

Loading