-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clippy1 no longer fails linting #906
Comments
Or perhaps it would be more appropriate to setup the lints in the source files themselves with something like: |
I was working on the exercise and this problem confused me a lot, so I think it needs to be fixed. |
I came to look at the issues today due to clippy not failing. FWIW, of the options discussed, I like adding #![deny(clippy::float_cmp)] best as a quick fix, as it expands on the lesson. |
Thanks for the advice. |
The relative
float_cmp
lint has been demoted from the correctness category (default deny) to pedantic (default allow) in the following PR:rust-lang/rust-clippy#7692
Consequently, the clippy1 exercise doesn't fail linting and leaves the user with nothing to fix. Possible solutions include rewriting the exercise to leverage another lint or adding the
-D clippy::float_cmp
arguments when invokingclippy
.The text was updated successfully, but these errors were encountered: