Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add:Third-Party List about rustlings-jp on README #2118

Closed
sotanengel opened this issue Sep 24, 2024 · 5 comments
Closed

Add:Third-Party List about rustlings-jp on README #2118

sotanengel opened this issue Sep 24, 2024 · 5 comments

Comments

@sotanengel
Copy link
Contributor

sotanengel commented Sep 24, 2024

Thank you for creating great exercises!!
Thanks to these exercises, I not only know more about Rust, but I like Rust even more :)

I have created a third-party repository with Japanese translations of this exercise
so that more people in my country(Japan) will know about it and be able to use Rust.
https://github.com/sotanengel/rustlings-jp/tree/main

Then, I added link link to my translated repository at README of Rustlings.
Could you check it?

#2117

@mo8it
Copy link
Contributor

mo8it commented Sep 26, 2024

Thank you very much for the translation! I would love to add it to the README. But first, you need to fix the info.toml file to include the translated hints.

This directory isn't needed: https://github.com/sotanengel/rustlings-jp/tree/main/create_info_data

You should use the original info.toml file instead. welcome_message, final_message and all hints need to be translated.

@sotanengel
Copy link
Contributor Author

Thank you for checking my repository!
I 'm going to delete unneeded folder create_info_data and add translated hints!
When finished, I will mention you at here 🙇

@sotanengel
Copy link
Contributor Author

@mo8it

I finished fix points!
Cloud you check it??

・Delete un-need folder
Image
Image

・Add all hints
https://github.com/sotanengel/rustlings-jp/blob/20240829/info.toml

@sotanengel
Copy link
Contributor Author

I re-create new PR, so please check below🙇
#2121

@mo8it
Copy link
Contributor

mo8it commented Oct 9, 2024

I merged the PR. But please make sure that you merge the branch 20240829 with the changes into the main branch.

Thank you for the translation :D

@mo8it mo8it closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants