Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show whether a type has drop glue (or a direct drop impl) on hover #18947

Open
Veykril opened this issue Jan 16, 2025 · 2 comments · May be fixed by #18987
Open

Show whether a type has drop glue (or a direct drop impl) on hover #18947

Veykril opened this issue Jan 16, 2025 · 2 comments · May be fixed by #18987
Assignees
Labels
A-hover hover feature C-feature Category: feature request

Comments

@Veykril
Copy link
Member

Veykril commented Jan 16, 2025

Drop glue is one of those implicit things thats hard to verify manually, rust-analyzer should allow you to easily tell whether there is drop glue or not

@Veykril Veykril added A-hover hover feature C-feature Category: feature request labels Jan 16, 2025
@ChayimFriedman2
Copy link
Contributor

Note that we need to know about drop existence for borrowck anyway (eventually), so adding it to the IDE is trivial enough.

@ChayimFriedman2 ChayimFriedman2 self-assigned this Jan 18, 2025
@ChayimFriedman2
Copy link
Contributor

Actually, there is a conflict between IDE and compiler needs: when there are type parameters, we want IDE to not always show "has drop glue", but compiler needs to mark them as having drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-hover hover feature C-feature Category: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants