Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert_tuple_struct_to_named_struct produces invalid code #18766

Open
adaszko opened this issue Dec 27, 2024 · 2 comments · May be fixed by #18912
Open

convert_tuple_struct_to_named_struct produces invalid code #18766

adaszko opened this issue Dec 27, 2024 · 2 comments · May be fixed by #18912
Assignees
@vishruth-thimmaiah
Labels
A-assists A-macro macro expansion C-bug Category: bug

Comments

@adaszko
Copy link
Contributor

adaszko commented Dec 27, 2024 •
edited by rustbot
Loading

rust-analyzer version: 2024-12-23

rustc version: rustc 1.83.0 (90b35a623 2024-11-26)

editor or extension: Reproduced under both Neovim and VSCode

code snippet to reproduce:

// add your code here
use std::{borrow::Borrow, debug_assert, rc::Rc};

#[derive(Clone, PartialEq)]
pub enum Expr {
    NontailCommand(Ustr, usize, ChicSpan),
}

#[cfg(test)]
pub mod tests {
    use super::*;
    use Expr::*;

    #[test]
    fn parses_nontail_command() {
        assert!(matches!(e, NontailCommand(s, 0, ..) if s == "foo"));
    }
}

Reproduction:

  1. Position cursor at Expr::NontailCommand and select "convert to named struct" code action:
Image 2. Code action inserts unexpected text in the first line of the buffer:Image

Same thing under VSCode:
Image
@adaszko adaszko added the C-bug Category: bug label Dec 27, 2024
@adaszko adaszko changed the title convert_tuple_struct_to_named_struct clobbers Neovim buffer convert_tuple_struct_to_named_struct produces invalid code Dec 27, 2024
@adaszko adaszko changed the title convert_tuple_struct_to_named_struct produces invalid code convert_tuple_struct_to_named_struct produces invalid code Dec 27, 2024
@Veykril
Copy link
Member

Veykril commented Dec 27, 2024

Looks like the assist is not upmapping ranges out of macro expansions

@Veykril Veykril added A-macro macro expansion A-assists labels Dec 27, 2024
@vishruth-thimmaiah
Copy link
Contributor

@rustbot claim

vishruth-thimmaiah added a commit to vishruth-thimmaiah/rust-analyzer that referenced this issue Jan 10, 2025
@vishruth-thimmaiah
fix: upmpap ranges in convert_tuple_struct_to_named_struct assist
6f6e95b 
fixes rust-lang#18766
vishruth-thimmaiah added a commit to vishruth-thimmaiah/rust-analyzer that referenced this issue Jan 10, 2025
@vishruth-thimmaiah
fix: upmap ranges in convert_tuple_struct_to_named_struct assist
75cb37e 
fixes rust-lang#18766
@vishruth-thimmaiah vishruth-thimmaiah linked a pull request Jan 10, 2025 that will close this issue
Open
vishruth-thimmaiah added a commit to vishruth-thimmaiah/rust-analyzer that referenced this issue Jan 16, 2025
@vishruth-thimmaiah
fix: upmap ranges in convert_tuple_struct_to_named_struct assist
9416241 
fixes rust-lang#18766
vishruth-thimmaiah added a commit to vishruth-thimmaiah/rust-analyzer that referenced this issue Jan 20, 2025
@vishruth-thimmaiah
fix: upmap ranges in convert_tuple_struct_to_named_struct assist
0b2b04f 
fixes rust-lang#18766
vishruth-thimmaiah added a commit to vishruth-thimmaiah/rust-analyzer that referenced this issue Jan 20, 2025
@vishruth-thimmaiah
fix: upmap ranges in convert_tuple_struct_to_named_struct assist
bbd09b5 
fixes rust-lang#18766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishruth-thimmaiah vishruth-thimmaiah

Labels
A-assists A-macro macro expansion C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: upmap ranges in convert_tuple_struct_to_named_struct assist vishruth-thimmaiah/rust-analyzer
3 participants
@adaszko @Veykril @vishruth-thimmaiah