Add support for textDocument/documentLink on imports

[osiewicz]

It would be great to have RA support textDocument/documentLink.
In particular having documentation links associated with spans of import statements would be superb; gopls already does it, where cmd-clicking on import name takes you to the docs for a given package.
RA already has "Open docs" command for VSC, but that's a spec extension.

I would be happy to work on that if the core team would be willing to accept such contribution.

[Veykril]

In particular having documentation links associated with spans of import statements would be superb; gopls already does it, where cmd-clicking on import name takes you to the docs for a given package.

I am not sure I quite follow, do you mean in the following:

use std::vec::Vec;

control clicking the Vec should open the documentation site for Vec? I am not sure I'd like that, control clicking in VSCode today brings you to the declaration there so this would be at odds with that.

[osiewicz]

Yeah, that's the interaction I'm suggesting. I can see your point (I tend to use that myself sometimes).
Admittedly, I mostly just want to bring "open docs" support to Zed without having to resort to supporting a protocol extension.

[Veykril]

Sorry this took a bit longer, was thinking this a bit.

So to me this doesn't feel quite right, textDocument/documentLink to me implies (the docs are rather vague on it tbf) that it yields ranges that act as links to resources, think of URIs and file paths in comments / strings (most of which an editor natively already does). It does not sound right to me that this would mark all identifiers (or a specific subset) of a document as links to their docs of what they resolve to.

The only thing I'd see we'd support here would be resolving intradoclinks (rust specific construct) within doc comments (and other kinds of links within them), though we also already resolve those to their corresponding definition.