Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock skew for service provider #57

Open
angusshire opened this issue Jul 15, 2019 · 3 comments
Open

Clock skew for service provider #57

angusshire opened this issue Jul 15, 2019 · 3 comments

Comments

@angusshire
Copy link

angusshire commented Jul 15, 2019

If the IdP and SP times are out of sync, then the SP may end up mistaking a valid SAML assertion as invalid. Therefore, we should be able to specify a clock skew to use for the service provider so that values within clock skew range of the NotBefore, NotOnOrAfter, or SessionNotOnOrAfter constraints are treated as valid.

@konaraya
Copy link

konaraya commented Aug 8, 2020

PR #71 for this feature. Please let me know your inputs.

@mfridman
Copy link
Contributor

+1 for adding a configurable clock skew up to a limit, say 5 min. At which point should probably fix the cause of the skew instead of extending the skew.

@lpar
Copy link

lpar commented May 20, 2022

Would also like. Active Directory tends to issue SAML assertions with NotBefore times with millisecond precision and no margin for error or clock drift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants