Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning on non-test analysis w/o foundry_success checking #386

Closed
palinatolmach opened this issue Feb 21, 2024 · 1 comment · Fixed by #432
Closed

Add a warning on non-test analysis w/o foundry_success checking #386

palinatolmach opened this issue Feb 21, 2024 · 1 comment · Fixed by #432
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@palinatolmach
Copy link
Collaborator

Related: #312

In Kontrol, we only check foundry_success predicate (and, therefore, report the test as failing) if the name of the test starts with test, check, or prove (#249). Once #312 is fixed, we'll be able to also check hevm_success predicate.

However, right now, if the test doesn't start from one of these three prefixes, it is being symbolically explored, but does not get reported as failing even if the test reverts. As reported by @dwightguth, it is confusing and looks like a bug, so we should probably emit a warning that informs the user that the test is not being checked for failures.

@palinatolmach palinatolmach added enhancement New feature or request good first issue Good for newcomers labels Feb 21, 2024
@ehildenb
Copy link
Member

This is intended behavior though for methods without test_ prefix, so that the user can create a summary to be used in running other tests/functions (via the --include-summary ... option). So a warning seems too strong here, maybe some documentation, or an INFO log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants