Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test selection if no --match-test is provided #382

Closed
palinatolmach opened this issue Feb 21, 2024 · 0 comments · Fixed by #383
Closed

Refactor test selection if no --match-test is provided #382

palinatolmach opened this issue Feb 21, 2024 · 0 comments · Fixed by #383
Assignees
Labels
engagement enhancement New feature or request

Comments

@palinatolmach
Copy link
Collaborator

palinatolmach commented Feb 21, 2024

The logic for selecting tests for verification if no --match-test is provided should be refactored to:

  • include tests that start with check and prove, in addition to test, following a similar change in Verify proveX and checkX functions similarly to testX #249
  • include test contracts that do not end with Test (e.g., our Optimism proof contract is called OptimismPortalKontrol), but, instead include the contracts located in the test folder

The refactoring should happen in the all_tests function:

   @cached_property
   def all_tests(self) -> list[str]:
       return [
           f'{contract.name_with_path}.{method.signature}'
           for contract in self.contracts.values()
           if contract.name_with_path.endswith('Test')
           for method in contract.methods
           if method.name.startswith('test')
       ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engagement enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant