Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Allow passing credentials at runtime in VertexAIVectorStore #17579

Open
naseemshah opened this issue Jan 22, 2025 · 0 comments
Labels
enhancement New feature or request triage Issue needs to be triaged/prioritized

Comments

@naseemshah
Copy link

Feature Description

Currently, the VertexAIVectorStore class requires credentials to be provided through a file path (credentials_path). This method may not be ideal in certain scenarios where credentials are available at runtime, such as in cloud environments where the credentials are automatically injected or managed through environment variables. It would be great if this class could also support passing credentials directly as a parameter (e.g., credentials=credentials), instead of being restricted to using the credentials_path.

from google.auth import credentials

credentials = service_account.Credentials.from_service_account_info("service account json string")

vector_store = VertexAIVectorStore(
    project_id=PROJECT_ID,
    region=REGION,
    index_id=vs_index.resource_name,
    endpoint_id=vs_endpoint.resource_name,
    gcs_bucket_name=GCS_BUCKET_NAME,
    credentials=credentials  # Pass credentials directly
)

Reason

No response

Value of Feature

No response

@naseemshah naseemshah added enhancement New feature or request triage Issue needs to be triaged/prioritized labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Issue needs to be triaged/prioritized
Projects
None yet
Development

No branches or pull requests

1 participant