Bug: editing volunteer email fails to save

[compwron]

Impacted User Types

• volunteers?
• supervisors?
• admins?

Environment

prod

Current Behavior

try to update volunteer email, fails to save - there's not a save button, insta-save ? Submit button - reimbursement seciton.. UI issues?

ex: When I click "generate report," no report is generated.
Please include a screenshot!

Expected Behavior

ex: When I click "generate report", a downloadable report should be generated.

How to Replicate

ex:

1. • Log in as an admin or supervisor.
2. • Click on "Generate Reports" in the left sidebar menu.
3. • Filter by a volunteer who has logged at least one case contact.
4. • Click "Generate report" at the bottom of the page.

How to access the QA site

Login Details:
Link to QA site

Login Emails:

• volunteer1@example.com view site as a volunteer
• supervisor1@example.com view site as a supervisor
• casa_admin1@example.com view site as an admin
• all_casa_admin1@example.com view site as an all casa admin
  • go to /all_casa_admins/sign_in

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

[Budmin]

Hey, I'd like to take a look at this

[compwron]

@Budmin go for it!

[Budmin]

@compwron Looking for some direction on this.

try to update volunteer email, fails to save - there's not a save button, insta-save ? Submit button - reimbursement seciton.. UI issues?

There's a "Submit" button that works differently when developing locally and when testing this on the QA site.

Locally:

After hitting submit a confirmation email goes out to the user, and once they click on the confirmation the email updates.

QA:

Same idea, but I couldn't get the email to send. Not sure if this just isn't set up for QA on purpose and it works on the proper site, or if it's supposed to work on the QA site.

---

There is a notice message that says "Volunteer was successfully updated. Confirmation Email Sent." when updating an email, but the email doesn't actually change until the volunteer clicks on the confirmation link in their email.

This all seems to be handled by devise, and I didn't think fiddling with devise configs was a good idea unless it was clear that's the direction you all want this to go.

Right now, I'm leaning towards this being a UI issue. Making it a little clearer what the Submit button does, and making the update message more accurate to what is actually happening when an email is waiting to be confirmed.

However you want to take care of this is fine with me, I'd just like to know if I'm on the right track with this.

[github-actions]

This issue has been inactive for 258 hours (10.75 days) and will be unassigned after 102 more hours (4.25 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

[compwron]

QA email doesn't send on purpose, to prevent spam.

the email doesn't actually change until the volunteer clicks on the confirmation link in their email.
hmm interesting, seems reasonable, just bad for our use case.

@compwron Looking for some direction on this.

try to update volunteer email, fails to save - there's not a save button, insta-save ? Submit button - reimbursement seciton.. UI issues?

There's a "Submit" button that works differently when developing locally and when testing this on the QA site.

Locally:

After hitting submit a confirmation email goes out to the user, and once they click on the confirmation the email updates.

QA:

Same idea, but I couldn't get the email to send. Not sure if this just isn't set up for QA on purpose and it works on the proper site, or if it's supposed to work on the QA site.

There is a notice message that says "Volunteer was successfully updated. Confirmation Email Sent." when updating an email, but the email doesn't actually change until the volunteer clicks on the confirmation link in their email.

This all seems to be handled by devise, and I didn't think fiddling with devise configs was a good idea unless it was clear that's the direction you all want this to go.

Right now, I'm leaning towards this being a UI issue. Making it a little clearer what the Submit button does, and making the update message more accurate to what is actually happening when an email is waiting to be confirmed.

However you want to take care of this is fine with me, I'd just like to know if I'm on the right track with this.

[Budmin]

@compwron
Makes sense on the QA site.

If you think that the email confirmation doesn't work for our use case, I'll make the changes that make the submit button just update the record.

If you'd like me to change my solution just let me know

[compwron]

@Budmin yes please make the submit button just update the record. I know it's not normal best practice but in the CASA context it's reasonable. Thanks!