-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Fix for 1 vulnerabilities #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -48,8 +48,8 @@ | |||||
| "classnames": "^2.2.6", | ||||||
| "decimal.js": "^10.2.0", | ||||||
| "lodash-es": "^4.17.15", | ||||||
| "npm": "^6.11.3", | ||||||
| "nuxt": "^2.9.2", | ||||||
| "npm": "^7.21.0", | ||||||
| "nuxt": "^3.0.0", | ||||||
|
||||||
| "nuxt": "^3.0.0", | |
| "nuxt": "^2.18.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade from npm 6.11.3 to 7.21.0 is unnecessary and problematic. Having npm as a production dependency is unusual - npm is typically a tool used to install dependencies, not a dependency itself.
Additionally, npm 7.x introduced breaking changes including:
If npm is truly needed as a dependency for this project, consider whether the tar vulnerability can be addressed through updating transitive dependencies without requiring a major version upgrade of npm itself. If npm is not actually used in the application code, it should be removed from dependencies entirely.