Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 dependency to gemspec or inline implementation #419

Open
jeremyevans opened this issue Sep 19, 2023 · 1 comment
Open

Add base64 dependency to gemspec or inline implementation #419

jeremyevans opened this issue Sep 19, 2023 · 1 comment

Comments

@jeremyevans
Copy link

Starting in Ruby 3.3.0-preview2, requiring net-ldap warns:

$ ruby33 -r net/ldap -e ''
/usr/local/lib/ruby/gems/3.3/gems/net-ldap-0.18.0/lib/net/ldap/password.rb:5: warning: base64 which will be not part of the default gems since Ruby 3.4.0

base64 will move from a standard library gem to a bundled gem in Ruby 3.4.0. That will break applications using bundler and net-ldap unless net-ldap declares a dependency on base64 or inlines the necessary implementation. Note that base64 was not gemified until Ruby 3.0, but the current base64 gem supports Ruby 2.4.0+, so this would result in dropping support for Ruby 2.0-2.3.

In my own libraries, I've chosen to inline the implementation, as base64 is a thin wrapper around String#unpack1 and Array#pack.

@jeremyevans
Copy link
Author

This issue has not yet been addressed, so applications using net-ldap on Ruby 3.4 are broken when using bundler, unless they have base64 in the Gemfile either directly or indirectly via a different gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant