Autocorrect for FactoryBot/IdSequence is NOT SAFE when ids are not generated automatically

[kyori19]

• Related
  • Add FactoryBot/IdSequence cop #52 (comment)
  • Ability to disable reject_primary_key_attributes per factory thoughtbot/factory_bot_rails#438

Removing sequence(:id) automatically breaks the factory, not only for non-database POROs, but also DB models with id is not generated. According to the issue thoughtbot/factory_bot_rails#438, such models exist on some applications. Thus, I think FactoryBot/IdSequence should not be marked as SAFE.

[MrJoy]

To add to this: The cop identified the following as something that could be removed, resulting in a semantic change that broke some specs for me:

sequence(:id) { |n| n.to_s }