Remove `Capybara/ClickLinkOrButtonStyle` cop

[ydah]

#61 (comment)

[Uaitt]

Hey @ydah,

on the current latest release of rubocop-capybara, this cop default is strict. However, since #76 was merged a month ago, the documentation actually says that the default is link_or_button, even thought a release with that change has not been issued.

Even though you are planning to delete this cop, I think you should at least create a new release with the up to date default - this discrepancy between the cop and the documentation can be a pain to rationalise 😢

[zspencer]

@ydah I would prefer that we keep this cop; but perhaps have it turned off by default? My team loves that we can rely on it to help us make good accessibility decisions when writing end-to-end tests.

Of course, it's also possible that having this in the linter is "too much" and people who like it can make a rubocop-capybara-accessibility gem and include it!

[ydah]

@zspencer I think proceeding in the direction of deleting Capybara/ClickLinkOrButtonStyle while creating a transition destination as follows. If you have any opinions, I would like to hear them.

• Add Capybara/AmbiguousClick cop and make soft-deprecated Capybara/ClickLinkOrButtonStyle cop. If you want to use EnforcedStyle: strict, use Capybara/AmbiguousClick cop instead #99

[zspencer]

@ydah This is great! I love it!

[mockdeep]

@zspencer I don't understand how this helps with accessibility. Just because your test specifies that something should be a button or a link doesn't guarantee that you've made it accessible.

We've standardized on click_on to avoid needing to update a bunch of tests when a button changes to a link or vice versa, which tends to happen when we switch some interaction between a full page and a modal experience. We've also got overrides to run a11y checks on every click, which is easier to implement when we've only got a single method to override.