Skip to content

Commit 143e310

Browse files
GijsWeteringsfacebook-github-bot
authored andcommitted
Fix xplat/endtoend/jest-e2e/apps/facebook_xplat/ReactNativeCoreE2E/__tests__/Border-corner-radii-elevation-percentages-e2e.js to actually use the right example (facebook#44525)
Summary: Pull Request resolved: facebook#44525 These examples were added, but their names were duplicated. This caused our internal e2e tests to accidentally target the wrong examples. Changelog: [General][Fixed] RNTester examples for border percentages are now properly covered by E2E screenshot tests. Reviewed By: NickGerleman Differential Revision: D57207306 fbshipit-source-id: 32ed5cc6b136a8928b11afe8b824c752edcdd9e5
1 parent 01afb08 commit 143e310

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

packages/rn-tester/js/examples/Border/BorderExample.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,9 @@ const styles = StyleSheet.create({
126126
},
127127
border9Percentages: {
128128
borderWidth: 10,
129-
borderTopLeftRadius: '10%',
130-
borderBottomRightRadius: '20%',
131-
borderColor: 'black',
129+
borderTopLeftRadius: '20%',
130+
borderBottomRightRadius: '10%',
131+
borderColor: 'red',
132132
},
133133
border10: {
134134
borderWidth: 10,
@@ -141,9 +141,9 @@ const styles = StyleSheet.create({
141141
border10Percentages: {
142142
borderWidth: 10,
143143
backgroundColor: 'white',
144-
borderTopLeftRadius: '10%',
145-
borderBottomRightRadius: '20%',
146-
borderColor: 'black',
144+
borderTopLeftRadius: '20%',
145+
borderBottomRightRadius: '10%',
146+
borderColor: 'red',
147147
elevation: 10,
148148
},
149149
border11: {
@@ -359,7 +359,7 @@ export default ({
359359
},
360360
{
361361
title: 'Corner Radii (Percentages)',
362-
name: 'corner-radii',
362+
name: 'corner-radii-percentages',
363363
description: 'borderTopLeftRadius & borderBottomRightRadius',
364364
render: function (): React.Node {
365365
return (
@@ -386,7 +386,7 @@ export default ({
386386
},
387387
{
388388
title: 'Corner Radii / Elevation (Percentages)',
389-
name: 'corner-radii-elevation',
389+
name: 'corner-radii-elevation-percentages',
390390
description: 'borderTopLeftRadius & borderBottomRightRadius & elevation',
391391
platform: 'android',
392392
render: function (): React.Node {

packages/rn-tester/js/examples/View/ViewExample.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,7 @@ export default ({
649649
},
650650
{
651651
title: 'Rounded Borders (Percentages)',
652-
name: 'rounded-borders-percentage',
652+
name: 'rounded-borders-percentages',
653653
render(): React.Node {
654654
return (
655655
<View

0 commit comments

Comments
 (0)