-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TypeScript support #9
Comments
Hello! I'm interested in this issue, especially for React. |
@togami2864 Perfect. I've added a checklist with a few items that you can get started with. Let me know if you need anything else! |
@rtkg12 This project is built with CRA commands, so I need to set up the environment to develop with typescript. |
@togami2864 Sorry, I'm confused. What do you mean? |
@ya-nsh Please feel free to take any of the files in the main checklist and indicate you're working on that in a comment. |
Hi @rtkg12 , is there anyone working with these issue ?, i've been trying to refactor some component to typescript, can i open a PR for this issue? |
I would love to help with this |
Hello, I am interested to work on this. I will work on client/src/components/PlaylistCard.js file |
Hello, I don't know if this project is still alive, but it looked fun and I wanted to see how far I could get. I have a pull request open for adding typescript support for all files in the client workspace. I checked functionality of the logged in and logged out states, everything still seems to work, but maybe best to double check. There's some possible future improvements: there are some "any" types when I couldn't check the functionality to make sure, like in the SearchPlaylist component which doesn't seem to be actively used. |
It might be a good idea to start adding TypeScript support to the React and Node.js code as more people are starting to contribute to the repo. I'm just creating this issue to gauge interest in this. This would probably require at least a few people working on it since there are a lot of different files, so please feel free to indicate if you'd be interested in working on it.
This should be a straightforward PR and would help you to get acquainted with the codebase in case you're interested in contributing.
If you are interested in working on this, check off a file that isn't being worked on currently and submit a PR before starting work on the next item in the list. I have put a few files that should be easy to start with and I'll keep adding more as these ones get done.
Checklist:
React:
The text was updated successfully, but these errors were encountered: