Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to parameter sliders #6

Open
rtkg12 opened this issue Sep 29, 2020 · 9 comments
Open

Add icons to parameter sliders #6

rtkg12 opened this issue Sep 29, 2020 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs

Comments

@rtkg12
Copy link
Owner

rtkg12 commented Sep 29, 2020

The sliders for the parameters could use icons or text to provide some more information about them. For example, less energetic, more energetic or other labels. This should be a very low effort PR so please feel free to assign it to yourself and discuss any suggestions that you have.

@rtkg12 rtkg12 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers up-for-grabs hacktoberfest labels Sep 29, 2020
@SaravgiYash
Copy link

SaravgiYash commented Sep 29, 2020

Hi, @rtkg12 I would like to work on this issue. Could you please describe what changes I need to make and in which file?
I will create the PR on 1st Oct.

@rtkg12
Copy link
Owner Author

rtkg12 commented Sep 30, 2020

Hi @Yashs911, please look at the ParametersMenu component for this. All that's needed for this is some sort of label below each slider which gives more info about the range of that parameter. That could be an icon, some text or an emoji. Please let me know if you have any ideas.

@ya-nsh
Copy link

ya-nsh commented Oct 1, 2020

Hey @rtkg12 ! I would love to work on this issue. Can you assign me to it? If it is fixed, what more can I contribute to and where to start?
This is my first time contributing to open source.

@Jashnm
Copy link

Jashnm commented Oct 1, 2020

Hey @rtkg12 , I tried to implement some Ant design icons on the sliders and here's how it looks
Screenshot (339)

Should I go with these? Any suggestions?

@rtkg12
Copy link
Owner Author

rtkg12 commented Oct 13, 2020

@Jashnm Sorry about the delay. The icons look good overall and the style matches the rest of the app. But some of the feature icons aren't very relevant such as Popularity, Tempo and Acousticness. It would be great if you could find some other icons for those.

@irahrosete
Copy link

@rtkg12 can you assign me this one pls?

@kingsley113
Copy link

Hey @rtkg12,
I took a stab at adding the icons and made some custom ones for each slider.
Screen Shot 2022-01-31 at 7 07 15 PM
Let me know if you have any other suggestions for them. Thanks!

@0xClint
Copy link

0xClint commented Oct 9, 2022

Hey can I contribute to this?

@NightWolf2905
Copy link

Hey, I would love to work on this. Can i contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

8 participants