-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icons to parameter sliders #6
Comments
Hi, @rtkg12 I would like to work on this issue. Could you please describe what changes I need to make and in which file? |
Hi @Yashs911, please look at the ParametersMenu component for this. All that's needed for this is some sort of label below each slider which gives more info about the range of that parameter. That could be an icon, some text or an emoji. Please let me know if you have any ideas. |
Hey @rtkg12 ! I would love to work on this issue. Can you assign me to it? If it is fixed, what more can I contribute to and where to start? |
Hey @rtkg12 , I tried to implement some Ant design icons on the sliders and here's how it looks Should I go with these? Any suggestions? |
@Jashnm Sorry about the delay. The icons look good overall and the style matches the rest of the app. But some of the feature icons aren't very relevant such as Popularity, Tempo and Acousticness. It would be great if you could find some other icons for those. |
@rtkg12 can you assign me this one pls? |
Hey @rtkg12, |
Hey can I contribute to this? |
Hey, I would love to work on this. Can i contribute? |
The sliders for the parameters could use icons or text to provide some more information about them. For example, less energetic, more energetic or other labels. This should be a very low effort PR so please feel free to assign it to yourself and discuss any suggestions that you have.
The text was updated successfully, but these errors were encountered: