Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Navbar UI/Styling issues with bootswatch theme (bootstrap4) #193

Open
MadhulikaTanuboddi opened this issue Oct 27, 2021 · 1 comment
Assignees

Comments

@MadhulikaTanuboddi
Copy link
Contributor

301-bs-themes and 302-bootswatch-themes app's shinytest tests are failing.

This is happening with almost all the themes using bootstrap4.

The navbar background color being the primary change or difference, there are also font styles and text color differences with the nav items.

Check the following few examples from the screenshare while running the shinycoreci::fix_all_gha_branches() (ran on 10/27)

screenshare_-_2021-10-27_10_49_53_am.mp4
screenshare_-_2021-10-27_10_44_59_am.mp4
screenshare_-_2021-10-27_10_43_32_am.mp4
screenshare_-_2021-10-27_10_42_19_am.mp4
@MadhulikaTanuboddi
Copy link
Contributor Author

These issues are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants