Skip to content

Commit 2e2114f

Browse files
authored
fix(busy): Show pulse if only UI are recalculating (#4137)
* fix(busy): Show pulse if only UI are recalculating Because UI elements don't get spinners
1 parent 09d4155 commit 2e2114f

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

NEWS.md

+2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
* Small improvements to the default pulse busy indicator to better blend with any background. It's also now slightly smaller by default. (#4122)
66

7+
* When spinners and the pulse busy indicators are enabled, Shiny now shows the pulse indicator when dynamic UI elements are recalculating if no other spinners are present in the app. (#4137)
8+
79
## Bug fixes
810

911
* Fixed a bug in `conditionalPanel()` that would cause the panel to repeatedly show/hide itself when the provided condition was not boolean. (@kamilzyla, #4127)

inst/www/shared/busy-indicators/busy-indicators.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

srcts/extras/busy-indicators/busy-indicators.scss

+3-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,9 @@
100100
&.shiny-busy::after {
101101
@include shiny-page-busy;
102102
}
103-
&.shiny-busy:has(.recalculating)::after {
103+
// Hide the pulse if there are spinners on the page
104+
// (Note: UI outputs don't get spinners)
105+
&.shiny-busy:has(.recalculating:not(.shiny-html-output))::after {
104106
display: none;
105107
}
106108
&.shiny-busy:has(#shiny-disconnected-overlay)::after {

0 commit comments

Comments
 (0)