Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hankel Matrix and low rank approximation #3

Open
JuanCarlos-TiqueRangel opened this issue Jul 27, 2024 · 3 comments
Open

Update Hankel Matrix and low rank approximation #3

JuanCarlos-TiqueRangel opened this issue Jul 27, 2024 · 3 comments

Comments

@JuanCarlos-TiqueRangel
Copy link

Describe the bug
I have a couple of questions:

  1. The Hankel matrix is updating with the new data ? I saw in the code and it looks like that the Hankel matrix and the Up, Uf, Yp, Yf are not updating.
  2. The Low rank matrix approximation function is not used ?
  3. Finally, you may have an example of a MIMO system. The example you have for the two tanks is a plat with just one input and one output.

Thank you in advance.

@Zionshang
Copy link

Hello! Great questions!
I'm trying to make a better DeeMPC based on this repository.
Can you provide some papers about the Hankle matrix that is updated with the new data? As far as I know, in most DeeMPC papers, the Hankle matrix are all built offline and then never updated.

@rssalessio
Copy link
Owner

Hi @JuanCarlos-TiqueRangel

  1. the Hankel matrix, from what I remember, is not updated to avoid introducing bias in the identification process (because we have closed loop data).
  2. No it was not used. I updated the example to show how it can be used (see explained_variance variable). However, it is quite shaky.
  3. Thanks for pointing this out. I fixed the example so now it's a proper MIMO system with two inputs/outputs.

@JuanCarlos-TiqueRangel
Copy link
Author

Hi @JuanCarlos-TiqueRangel

  1. the Hankel matrix, from what I remember, is not updated to avoid introducing bias in the identification process (because we have closed loop data).
  2. No it was not used. I updated the example to show how it can be used (see explained_variance variable). However, it is quite shaky.
  3. Thanks for pointing this out. I fixed the example so now it's a proper MIMO system with two inputs/outputs.

Thank you very much I will check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants