Inhibit chmod #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Docker content from community.general migrated to community.docker. * Hetzner Robot content from community.general migrated to community.hrobot. * RouterOS content from community.network migrated to community.routeros. * PostgreSQL content from community.general migrated to community.postgresql. * OC content from community.general migrated to community.okd. * Cisco NSO content from community.network migrated to cisco.nso. * Add changelog fragment. * Google content from community.general migrated to community.google. * Hashi Vault content from community.general migrated to community.hashi_vault. * KubeVirt content from community.general migrated to community.kubevirt. * FortiOS content from community.network migrated to community.fortios. * Update changelog fragment. * DellEMC content from community.general migrated to dellemc.openmanage.
) When running in verbosity <2, display the file and line number for tasks that fail. This provides useful information without having to run at increased verbosity. * Move _print_task_path to CallbackBase class * Add integration tests * Add color parameter to _print_task_path() * Keep color output consistent for now Currently the path is display with COLOR_DEBUG formatting with verbosity >= 2. Instead of the color of the path changing based on verbosity level, just keep it at the currently behavior of COLOR_DEBUG. Having the color of the same information change based on verbosity level seems incorrect and makes visual parsing of the information more difficult. Co-authored-by: tahar.jegham <[email protected]>
…e#73541) * Add changelog and fixtures for AlmaLinux support Co-authored-by: Christoph Schug <[email protected]>
* Add integration test Co-authored-by: Sam Doran <[email protected]>
Co-authored-by: Abhijeet Kasurde <[email protected]> Co-authored-by: Alicia Cozine <[email protected]>
Signed-off-by: Rick Elrod <[email protected]>
* Upgrade pylint and deps in ansible-test. * Enable pylint on Python 3.9. * Update pylint config. * Add ignore for vendored six. * Add ignores for support plugins. * Fix issue reported by pylint.
* module compat for py3.8+ controller * replaced internal usages of selinux bindings with internal ctypes binding (allows basic selinux operations from any Python interpreter), plus tests * added new respawn_module API to allow modules to import Python packages that are only available under a well-known interpreter, plus tests * added respawn logic to modules that need Python libs from a specific system interpreter (apt, apt_repository, dnf, yum) minimize internal HAVE_SELINUX usage spurious junk pep8 * pylint fixes * add RHEL8 Python 3.8 testing * more pylint * import sanity * unit tests * changelog update * fix a bunch of stuff * tweak changelog * fix setup_rpm_repo on EL8 * misc sanity/test fixes * misc feedback tweaks * fix import fallback in test module * fix selinux MU test * fix dnf tests to avoid python-dependent test packages * add trailing LFs to aliases * fix yum tests to avoid test package with Python deps * hack create_repo for EL6 to create noarch package
Only add data when there is data to add also avoid clobbering existing data with empty file fixes ansible#45843 * remove redundant code, update comments * fix mock dataloader, original does not return None * added test
for those that had choices that didn't match actual values used
Until now, the lookup plugin returned a byte string. Changed this to output a unicode string instead.
Co-authored-by: Deric Crago <[email protected]> Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: John R Barker <[email protected]> Co-authored-by: Deric Crago <[email protected]> Co-authored-by: Alicia Cozine <[email protected]>
Add argument spec validator class
* Silence Python 3.5 EOL notice in pip. * Skip import test on compat/selinux.py utils. * Improve Python version skip warning. * Use Python 3.6 as minimum Python for sanity tests. * Improve min Python handling for code-smell tests. * Overhaul test-constraints sanity test. * Merge sanity test constraints with requirements. * Remove legacy content specific constraints. * Add changelog fragment.
* Use valid FQCN in test_verbosity_arguments * Use iskeyword and str.isidentifier for "is FQCN"
Ensure `yamllint`'s `check_assignment()` correctly ignore the attribute assignment. Those don't have any `.id` attribute and will trigger an `AttributeError` exception. See: ansible#73322
Allow constructed to optionally use vars plugin data * mostly for those looking to leverage group_vars/ and host_vars/ * limited to already processed sources
* corrected description info
* Initial import of modified version of alikins' code * Add unit testing for new Role methods * Fix validate_arg_spec module for sanity test. Add test_include_role_fails.yml integration test from orig PR. * Add testing of suboptions * Use new ArgumentSpecValidator class instead of AnsibleModule * fix for roles with no tasks, use FQ name of new plugin * Add role dep warning
…e community guide, (ansible#73574) * Added conscious language note to index pages of guides
* Add rolespec_validate to import/include_role * Add changelog * fix sanity, not private
* ansible-doc - account for empty meta/main.yml from_yaml() will return None when encrounting an empty file.
Change: - Tests for advanced_host_list; it is now at 100% coverage. - There was a typo (host vs hostnames) where when the host pattern failed to parse, instead of treating the name as a literal as intended, it would trigger UnboundLocalError. This didn't fatal as there's a global "Exception" handler below, but it did lead to an ugly error and incorrect behavior. Test Plan: - New tests - Local experimenting Signed-off-by: Rick Elrod <[email protected]> * changelog Signed-off-by: Rick Elrod <[email protected]> * fix tests Signed-off-by: Rick Elrod <[email protected]>
Change: - When a "distro" package exists in PYTHONPATH but isn't what we expect, fall back to our own vendored one and use it. This prevents a traceback if someone has some random thing that provides "distro" but isn't actually the "distro" library we need. Test Plan: - new tests Tickets: - Fixes ansible#74228 Signed-off-by: Rick Elrod <[email protected]> * nuke playbook test file Signed-off-by: Rick Elrod <[email protected]> * test fixes Signed-off-by: Rick Elrod <[email protected]>
…pe=any (ansible#74241) * add changelog * fix cl text * Update changelogs/fragments/74241-find-checks-size-with-any.yml Co-authored-by: Rick Elrod <[email protected]>
* satisfy the all-knowing, ever present God of Sanity and use 'grep -c' vs. 'wc -l'
…ng_separator' (ansible#74005) * Support omitting the trailing separator when a dictionary key's value is an empty string * Support a default value when the value used in the group name is an empty string * Add tests * change log
* various fixes to command - Updated splitter to allow for all expected args in ad-hoc - Ensure we always return the returns we promissed to always return (i.e stderr/stdout) - Updated docs to clarify creates/removes precdence in checking - Removed abspath from chdir to allow reporting to handle symlinks correctly - Corrected tests to new output messages Co-authored-by: Felix Fontein <[email protected]>
* all lookups to support config system - added get_options to get full dict with all opts - fixed tests to match new error messages - kept inline string k=v parsing methods for backwards compat - placeholder depredation for inline string k=v parsing - updated tests and examples to also show new way - refactored and added comments to most custom k=v parsing - added missing docs for template_vars to template - normalized error messages and exception types - fixed constants default - better details value errors Co-authored-by: Felix Fontein <[email protected]>
* updates list of available versions for Ansible 3 Co-authored-by: Alicia Cozine <[email protected]>
* deprecated include Update lib/ansible/modules/_include.py updated version numbers in schema check (real fix in separate PR) Co-authored-by: flowerysong <[email protected]> Co-authored-by: Matt Clay <[email protected]>
fixes ansible#74225 Co-authored-by: Kim Nørring <[email protected]>
Should still fit in 80 chars
* avoid 'mixed' param formats * added tests * clog * fixed alignment
* Prevent ansible_failed_task from further templating Fixes ansible#74036 * Add changelog
* Catch errors getting filters, and fail * Add changelog * Switch to warnings instead of errors, to match other plugin loader behavior * Add tests * Handle collections
Change: - We were passing a directory name directly to re.compile(). If the directory isn't valid regex (or is) this can have odd side effects, such as crashing. - Fix a few other similar cases, but less likely to be a real issue. Test Plan: - New test Signed-off-by: Rick Elrod <[email protected]>
Signed-off-by: Randall S. Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Rebase of your change and added changelog artifact as requested by @samdoran
ISSUE TYPE
COMPONENT NAME
copy