-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the MINGW-package downstream patch #405
Comments
It is a small patch that fixes the issue that dictionaries are not found. |
I translated the patch to Vala and added it on a branch (see linked branch win32-relocatable). However, I would like to know more about why the patch is needed, and what the problem is in gnulib. Looking at gnulib's Also, I would rather make any patch to gnulib (since it does not rely on formal releases, I don't have to wait for that before then using a new version in Enchant). Finally, adding Windows-specific code to Enchant would mean that users would have to compile the Vala rather than the C sources, and hence would need to install a Vala compiler. |
Also, I don't seem to have the patch quite right yet, as it makes the Windows tests segfault: https://github.com/rrthomas/enchant/actions/runs/12637182516/job/35210842868#step:7:210 |
I'm not the author of the patch, so I don't know the details. I would need to investigate how it works and why it is needed. (A bit out of scope for me right now) |
Include the MINGW-package downstream patch.
See 001_fix_relocation.patch
The text was updated successfully, but these errors were encountered: