Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the MINGW-package downstream patch #405

Open
swilmet opened this issue Jan 5, 2025 · 4 comments
Open

Include the MINGW-package downstream patch #405

swilmet opened this issue Jan 5, 2025 · 4 comments

Comments

@swilmet
Copy link

swilmet commented Jan 5, 2025

Include the MINGW-package downstream patch.

See 001_fix_relocation.patch

@swilmet
Copy link
Author

swilmet commented Jan 5, 2025

It is a small patch that fixes the issue that dictionaries are not found.

rrthomas added a commit that referenced this issue Jan 6, 2025
@rrthomas
Copy link
Owner

rrthomas commented Jan 6, 2025

I translated the patch to Vala and added it on a branch (see linked branch win32-relocatable).

However, I would like to know more about why the patch is needed, and what the problem is in gnulib. Looking at gnulib's relocatable.c, it has a special DllMain function specifically for Win32, so it looks like relocatability should work; perhaps I'm not using it right?

Also, I would rather make any patch to gnulib (since it does not rely on formal releases, I don't have to wait for that before then using a new version in Enchant).

Finally, adding Windows-specific code to Enchant would mean that users would have to compile the Vala rather than the C sources, and hence would need to install a Vala compiler.

@rrthomas
Copy link
Owner

rrthomas commented Jan 6, 2025

Also, I don't seem to have the patch quite right yet, as it makes the Windows tests segfault: https://github.com/rrthomas/enchant/actions/runs/12637182516/job/35210842868#step:7:210

@swilmet
Copy link
Author

swilmet commented Jan 8, 2025

I'm not the author of the patch, so I don't know the details. I would need to investigate how it works and why it is needed. (A bit out of scope for me right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants