Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All 2.0.0 npm installs crash #62

Open
nickpascucci opened this issue Jun 12, 2018 · 3 comments
Open

All 2.0.0 npm installs crash #62

nickpascucci opened this issue Jun 12, 2018 · 3 comments

Comments

@nickpascucci
Copy link

The retyped command crashes when installing the 2.0.0 releases from npm.

  • ReasonablyTyped version: 2.0.0-beta4
  • bs-platform version: BuckleScript 3.1.5 (Using OCaml4.02.3+BS )
{SANDBOX} [17:39:43] /src/types/hellojs [master] > retyped index.d.ts
module.js:549
    throw err;
    ^

Error: Cannot find module './js/src/compiler'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/nick/.npm-global/lib/node_modules/reasonably-typed/lib/index.js:2:17)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
@bbqbaron
Copy link
Collaborator

This is just a matter of not having shipped the JS artifacts, right? For instance, I can fix this by running bsb -make-world in the install directory (not that that's the solution :P). I'm new at NPM, but is this just fixed by having a prepublishOnly hook that produces the JS artifacts? On the other hand (I was curious and browsed around) it looks like reason-react commits their artifacts to source. Does a more experienced NPM person know what to do?

@rrdelaney
Copy link
Owner

2.0 isn't ready yet, sorry! It still needs a ton of work to handle most cases. The main driving factor for 2.0 is to be the backing library for styled-scss, and it's super not ready for CLI usage

@dmtrKovalenko
Copy link

@rrdelaney please provide separate npm tag if you are publishing beta version like npm publish --tag next
But anyway if you are publishing it to npm it must be ready for usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants