Skip to content

Commit c764e39

Browse files
committed
Rename mktree.podman to mktree.oci
This name is a better fit as it puts more emphasis on the format of the resulting tree, not as much on the actual container engine used (which can be swapped, and currently is in the CI where we use docker instead of podman). Also drop the awkward .docker symlink now and instead pass the container engine through the MKTREE_ENGINE environment variable.
1 parent 9c5c5ac commit c764e39

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

.github/workflows/linux.yml

+5-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,11 @@ jobs:
99
steps:
1010
- uses: actions/checkout@v3
1111
- name: Build the Fedora testing environment
12-
run: ./mktree.docker build
12+
run: ./mktree.oci build
1313
working-directory: ./tests
1414
- name: Run the test suite
15-
run: ./mktree.docker check --interactive=false -j$(nproc)
15+
run: ./mktree.oci check --interactive=false -j$(nproc)
1616
working-directory: ./tests
17+
18+
env:
19+
MKTREE_ENGINE: docker

tests/CMakeLists.txt

+4-4
Original file line numberDiff line numberDiff line change
@@ -68,18 +68,18 @@ if (nproc GREATER 1)
6868
endif()
6969

7070
# Set up mktree
71-
set(MKTREE_BACKEND podman CACHE STRING "Mktree backend to use")
71+
set(MKTREE_BACKEND oci CACHE STRING "Mktree backend to use")
7272
set(DOCKERFILE ${CMAKE_CURRENT_SOURCE_DIR}/Dockerfile.${OS_NAME})
73-
if (MKTREE_BACKEND STREQUAL podman)
73+
if (MKTREE_BACKEND STREQUAL oci)
7474
find_program(PODMAN podman)
7575
find_program(DOCKER docker)
7676
mark_as_advanced(PODMAN DOCKER)
7777
if (PODMAN AND EXISTS ${DOCKERFILE})
7878
set(MKTREE_NATIVE yes)
7979
configure_file(${DOCKERFILE} Dockerfile COPYONLY)
8080
add_custom_target(ci
81-
COMMAND ./mktree.podman build
82-
COMMAND ./mktree.podman check ${JOBS} $(TESTOPTS)
81+
COMMAND ./mktree.oci build
82+
COMMAND ./mktree.oci check ${JOBS} $(TESTOPTS)
8383
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
8484
)
8585
else()

tests/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ The mode is selected automatically during cmake configuration based on the host
1818
distribution and the container engine installed, with native mode being
1919
preferred whenever possible, and is reported in the cmake output as follows:
2020

21-
-- Using mktree backend: podman (native: <yes|no>)
21+
-- Using mktree backend: oci (native: <yes|no>)
2222

2323
Then run the command
2424

tests/mktree.docker

-1
This file was deleted.

tests/mktree.podman tests/mktree.oci

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ else
1313
# Running from source directory
1414
CMAKE=no
1515
NATIVE=no
16-
PODMAN=$(echo $PROGRAM | cut -d'.' -f2)
16+
PODMAN=${MKTREE_ENGINE:-podman}
1717
CONTEXT=..
1818
fi
1919

0 commit comments

Comments
 (0)