Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose arch in Python bindings #91

Open
alebastr opened this issue Aug 16, 2022 · 1 comment
Open

Expose arch in Python bindings #91

alebastr opened this issue Aug 16, 2022 · 1 comment

Comments

@alebastr
Copy link

I'm trying to write a Python code that traverses the Fedora comps and writes a list of packages for the groups, grouping the packages by supported architectures (an update for comps-sync.py in Fedora's workstation-ostree-config).

The data we need, <packagereq arch="..." and <groupid arch="..." attributes are not exposed through the Python bindings. Would it be possible to add support for that?


I've tried to write the necessary bindings myself, but I lack the python C API knowledge required to debug a few remaining crashes. I can send a draft PR, but IMO it would be better if someone familiar with the codebase could work on that.

@AdamWill
Copy link

AdamWill commented Nov 2, 2022

You don't really need this. See my comps-sync PR. It also doesn't really match the way this was designed to work. The design is that you query filters by arch if you want results filtered by arch. A query that's not filtered is implicitly a query for all arches. This approach happens to make things slightly awkward for the way comps-sync.py wants to work, but I'm not sure that exposing this attribute in the results of the search is really the 'right thing' to do, given libcomps' actual design here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants