RepomdRecord "size_open" is initialized to -1, but "size" is uninitialized

[dralley]

I came across this unintuitive behavior just now. The value size on RepomdRecord defaults to 0 if not touched (but I think it's not an actual default, it's just uninitialized [0]). Whereas the value open_size defaults to -1.

[0] https://github.com/rpm-software-management/createrepo_c/blob/master/src/repomd.c#L55

Is this intended?

[dralley]

@kontura ^

[kontura]

Unfortunately the commit which introduced this isn't very helpful: eb9c50e

Looking at the code I think open_size is supposed to be optional, there is a condition which dumps the element only if it is different from -1 whereas size is dumped every time but this could have been possibly achieved with 0 as well..
(It is possible to use modifyrepo_c to add a --no-compress record which doesn't have open_size but it also doesn't set size which is present but 0. It doesn't seem to work very well.)

I can't think of any specific reason for this.