Skip to content

missing a ":" #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlanSwenson wants to merge 2 commits into
base: master
Choose a base branch
from
Open

missing a ":" #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11638bf
missing a ":"
AlanSwenson Mar 5, 2019
99a21bc
changes to the way hybrid properties works
AlanSwenson Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/users.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,8 @@ before being stored.
return self._password

@password.setter
def _set_password(self, plaintext):
self._password = bcrypt.generate_password_hash(plaintext)
def password(self, plaintext):
self._password = bcrypt.generate_password_hash(plaintext).decode("utf-8")

We're using SQLAlchemy's hybrid extension to define a property with
several different functions called from the same interface. Our setter
Expand Down Expand Up @@ -337,7 +337,7 @@ the hashed password stored for that user.

# [...] columns and properties

def is_correct_password(self, plaintext)
def is_correct_password(self, plaintext):
return bcrypt.check_password_hash(self._password, plaintext)


Expand Down