Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support #32

Open
utapyngo opened this issue Dec 8, 2016 · 4 comments
Open

Python 3 support #32

utapyngo opened this issue Dec 8, 2016 · 4 comments

Comments

@utapyngo
Copy link

utapyngo commented Dec 8, 2016

On Python 3 I get this error:

  File "...python3.5/site-packages/pynliner/__init__.py", line 222, in _get_external_styles
    self.style_string += self._get_url(url)
TypeError: Can't convert 'bytes' object to str implicitly

It's a pynliner problem.
I have already described it here and opened a pull request to fix this but @rennat seem to be too busy to review it.

Is there a way to make django-inlinecss work with Python 3?

@utapyngo
Copy link
Author

The pull request has been merged and released to pypi. Please release a new version that depends on pynliner instead of pynliner3.

@sebitoelcheater
Copy link

@utapyngo how did u solve it?

@utapyngo
Copy link
Author

Switched to django-mailcss.

@WhyNotHugo
Copy link
Contributor

Seems that this can be closed, Python 3 has worked now for a long while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants