Skip to content

Commit 8c686f2

Browse files
committed
Address merge conflicts
Signed-off-by: Michael Orlov <[email protected]>
1 parent e01b597 commit 8c686f2

File tree

5 files changed

+47
-275
lines changed

5 files changed

+47
-275
lines changed

rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp

+5-8
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@
3434

3535
#include "logging.hpp"
3636

37+
namespace fs = rcpputils::fs;
38+
3739
namespace rosbag2_compression
3840
{
3941

@@ -75,13 +77,8 @@ void SequentialCompressionWriter::compression_thread_fn()
7577
rcpputils::check_true(compressor != nullptr, "Could not create compressor.");
7678

7779
while (true) {
78-
<<<<<<< HEAD
7980
std::shared_ptr<rosbag2_storage::SerializedBagMessage> message;
80-
std::string file;
81-
=======
82-
std::shared_ptr<const rosbag2_storage::SerializedBagMessage> message;
8381
std::string closed_file_relative_to_bag;
84-
>>>>>>> 1877b538 (Bugfix for bag_split event callbacks called to early with file compression (#1643))
8582
{
8683
std::unique_lock<std::mutex> lock(compressor_queue_mutex_);
8784
compressor_condition_.wait(
@@ -120,7 +117,7 @@ void SequentialCompressionWriter::compression_thread_fn()
120117
// Execute callbacks from the base class
121118
static const std::string compressor_ext = "." + compressor->get_compression_identifier();
122119
auto closed_file =
123-
(fs::path(base_folder_) / (closed_file_relative_to_bag + compressor_ext)).generic_string();
120+
(fs::path(base_folder_) / (closed_file_relative_to_bag + compressor_ext)).string();
124121
std::string new_file;
125122
// To determine, a new_file we can't rely on the metadata_.relative_file_paths.back(),
126123
// because other compressor threads may have already pushed a new item above.
@@ -132,7 +129,7 @@ void SequentialCompressionWriter::compression_thread_fn()
132129
if (iter != metadata_.relative_file_paths.end()) {
133130
++iter;
134131
if (iter != metadata_.relative_file_paths.end()) {
135-
new_file = (fs::path(base_folder_) / *iter).generic_string();
132+
new_file = (fs::path(base_folder_) / *iter).string();
136133
}
137134
}
138135
}
@@ -333,7 +330,7 @@ void SequentialCompressionWriter::split_bagfile()
333330
compressor_file_queue_.push(last_file_relative_to_bag);
334331
compressor_condition_.notify_one();
335332
} else {
336-
auto last_file = (fs::path(base_folder_) / last_file_relative_to_bag).generic_string();
333+
auto last_file = (fs::path(base_folder_) / last_file_relative_to_bag).string();
337334
SequentialWriter::execute_bag_split_callbacks(last_file, new_file);
338335
}
339336

0 commit comments

Comments
 (0)