Skip to content

Commit 0c0b038

Browse files
committed
Skip check for custom_metadata in test for mcap storage plugin.
- Rationale: Mcap storage doesn't store serialized metadata in bag directly on Iron and Humble. Backporting of the relevant #1423 is not possible without updating mcap vendor package to the v1.1.0 because we have dependencies from the mcap_reader_->metadataIndexes(); API which became available only in the foxglove/mcap#902 Signed-off-by: Michael Orlov <[email protected]>
1 parent cac9ecb commit 0c0b038

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

rosbag2_tests/test/rosbag2_tests/test_reindexer.cpp

+9-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,15 @@ TEST_P(ReindexTestFixture, test_multiple_files) {
132132

133133
EXPECT_EQ(generated_metadata.storage_identifier, GetParam());
134134
EXPECT_EQ(generated_metadata.version, target_metadata.version);
135-
EXPECT_EQ(generated_metadata.custom_data, target_metadata.custom_data);
135+
136+
if (GetParam() != "mcap") {
137+
// Skip check for mcap storage since it doesn't store serialized metadata in bag directly on
138+
// Iron and Humble. Backporting of the relevant #1423 is not possible without updating
139+
// mcap vendor package to the v1.1.0 because we have dependencies from the
140+
// mcap_reader_->metadataIndexes(); API which became available only in the
141+
// https://github.com/foxglove/mcap/pull/902
142+
EXPECT_EQ(generated_metadata.custom_data, target_metadata.custom_data);
143+
}
136144

137145
for (const auto & gen_rel_path : generated_metadata.relative_file_paths) {
138146
EXPECT_TRUE(

0 commit comments

Comments
 (0)