-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add explanation about component containers. #4902
base: rolling
Are you sure you want to change the base?
Conversation
@christophebedard @clalancette can you take a look? thanks in advance. |
Signed-off-by: Tomoya.Fujita <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]>
94bf175
to
965d922
Compare
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/12440041148/artifacts/2350767133. To view the resulting site:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can follow up once ros2/rclcpp#2541 is merged.
Signed-off-by: Tomoya Fujita <[email protected]> Co-authored-by: Christophe Bedard <[email protected]>
2839672
to
f3aad80
Compare
@christophebedard thanks for doing review on this, most of your comments are addressed by f3aad80 just fyi, since i borrowed most of your suggestions, that put you as Co-Author. |
Signed-off-by: Tomoya Fujita <[email protected]>
@christophebedard thanks for checking on this, all comments are addressed. requesting review once again. |
* Component container that uses a dedicated executor for each component: either ``SingleThreadedExecutor`` (default) or ``MultiThreadedExecutor``. | ||
|
||
For more information about the types of executors, see the :ref:`TypesOfExecutors`. | ||
For more information about the option of each component container, see :ref:`ComponentContainerTypes` in the composition tutorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more information about the option of each component container, see :ref:`ComponentContainerTypes` in the composition tutorial. | |
For more information about the options of each component container, see :ref:`ComponentContainerTypes` in the composition tutorial. |
My bad, sorry!
closes #4901