Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failures with rmw_zenoh #286

Closed
Yadunund opened this issue Sep 26, 2024 · 30 comments
Closed

Test failures with rmw_zenoh #286

Yadunund opened this issue Sep 26, 2024 · 30 comments

Comments

@Yadunund
Copy link
Member

Yadunund commented Sep 26, 2024 •
edited
Loading

This ticket will track the status of test failures with rmw_zenoh.

Below is the template to be used with an example. Let's copy paste this each time we make changes to the ros2.repos file from
https://github.com/Yadunund/ros2/blob/yadu/rmw_zenoh_testing/ros2.repos

Test setup

rmw_zenoh/rolling

ROS Package Failing test name Failing test output
rclcpp 33 - test_intra_process_manager gist

rmw_zenoh/dev/1.0.0

ROS Package Failing test name Failing test output

Additional tips

  • Individual tests can be run with a command like colcon test --event-handlers console_direct+ --packages-select rcl --ctest-args -R test_graph
@Yadunund Yadunund pinned this issue Sep 26, 2024
@Yadunund Yadunund mentioned this issue Sep 26, 2024
Closed
@ahcorde
Copy link
Contributor

ahcorde commented Sep 27, 2024 •
edited
Loading

Test setup

rmw_zenoh/rolling

ROS Package Failing test name Failing test output
rcl None
rcl_action None
rcl_lifecyle None
rcl_yaml_param_parser None
rclcpp test_intra_process_manager description below
rclcpp test_node_interfaces__node_graph description below
rclcpp test_publisher description below
rclcpp test_qos description below
rclcpp test_events_executor Timeout
rclcpp test_wait_set description below
rclcpp_action None

test_node_interfaces__node_graph

44: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/node_interfaces/test_node_graph.cpp:645: Failure
44: Value of: endpoint_gid_is_all_zeros
44:   Actual: true
44: Expected: false

test_intra_process_manager

33: [WARN] [1727705634.805297595] [rclcpp]: Calling get_subscription_count for invalid or no longer existing publisher id
33: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_intra_process_manager.cpp:500: Failure
33: Expected equality of these values:
33:   1u
33:     Which is: 1
33:   p1_subs
33:     Which is: 2

test_publisher

62: [ERROR] [1727705680.331005842] [rclcpp]: Couldn't take event info: rmw_take_event called when event queue for event type [9] is empty, at /home/ahcorde/ros2_rolling/src/ros2/rmw_zenoh/rmw_zenoh_cpp/src/rmw_event.cpp:210, at /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/src/rcl/event.c:175
62: unknown file: Failure
62: C++ exception with description "'data' is empty" thrown in the test body.
62: 
62: [  FAILED  ] TestPublisher.run_event_handlers (7 ms)
62: [ RUN      ] TestPublisher.get_network_flow_endpoints_errors

test_qos

67: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_qos.cpp:249: Failure
67: Expected equality of these values:
67:   ret.compatibility
67:     Which is: 4-byte object <00-00 00-00>
67:   rclcpp::QoSCompatibility::Error
67:     Which is: 4-byte object <02-00 00-00>
67: 
67: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_qos.cpp:250: Failure
67: Value of: ret.reason.empty()
67:   Actual: true
67: Expected: false
67: 
67: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_qos.cpp:258: Failure
67: Expected equality of these values:
67:   ret.compatibility
67:     Which is: 4-byte object <00-00 00-00>
67:   rclcpp::QoSCompatibility::Warning
67:     Which is: 4-byte object <01-00 00-00>
67: 
67: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_qos.cpp:259: Failure
67: Value of: ret.reason.empty()
67:   Actual: true
67: Expected: false

test_wait_set

108: unknown file: Failure
108: C++ exception with description "Failed to initialize event: provided event_type 7 is not supported by rmw_zenoh_cpp, at /home/ahcorde/ros2_rolling/src/ros2/rmw_zenoh/rmw_zenoh_cpp/src/rmw_event.cpp:57" thrown in the test body.
108: 
108: [  FAILED  ] TestWaitSet.add_guard_condition_to_two_different_wait_set (13 ms)
108: [ RUN      ] TestWaitSet.add_remove_wait
108: unknown file: Failure
108: C++ exception with description "Failed to initialize event: provided event_type 1 is not supported by rmw_zenoh_cpp, at /home/ahcorde/ros2_rolling/src/ros2/rmw_zenoh/rmw_zenoh_cpp/src/rmw_event.cpp:114" thrown in the test body.

rmw_zenoh/dev/1.0.0

ROS Package Failing test name Failing test output
rcl test_graph__rmw_zenoh_cpp description below
rcl_action test_action_communication__rmw_zenoh_cpp description below
rcl_action test_action_communication__rmw_zenoh_cpp description below
rcl_action test_graph__rmw_zenoh_cpp description below
rcl_action test_action_server timeout
rcl_lifecyle test_rcl_lifecycle Timeout
rcl_yaml_param_parser None description below
rclcpp test_allocator_memory_strategy timeout
rclcpp test_intra_process_manager description below
rclcpp test_node_interfaces__node_graph description below
rclcpp test_parameter_client description below
rclcpp test_publisher description below
rclcpp test_qos description below
rclcpp test_wait_for_message description below
rclcpp test_events_executor timeout
rclcpp test_wait_set description below
rclcpp_action test_client timeout

test_action_communication (rcl_action)

11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:561: Failure
11: Expected equality of these values:
11:   ret
11:     Which is: 2
11:   0
11: error not set
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:573: Failure
11: Value of: this->is_status_ready
11:   Actual: false
11: Expected: true
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:581: Failure
11: Expected equality of these values:
11:   ret
11:     Which is: 4103
11:   0
11: error not set
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:584: Failure
11: Expected equality of these values:
11:   status_array.msg.status_list.size
11:     Which is: 1
11:   incoming_status_array.status_list.size
11:     Which is: 0

test_wait_set (rclcpp)

108: [ RUN      ] TestWaitSet.add_guard_condition_to_two_different_wait_set
108: unknown file: Failure
108: C++ exception with description "Failed to initialize event: provided event_type 7 is not supported by rmw_zenoh_cpp, at /home/ahcorde/ros2_rolling/src/ros2/rmw_zenoh/rmw_zenoh_cpp/src/rmw_event.cpp:53" thrown in the test body.
108: 
108: [  FAILED  ] TestWaitSet.add_guard_condition_to_two_different_wait_set (16 ms)
108: [ RUN      ] TestWaitSet.add_remove_wait
108: unknown file: Failure
108: C++ exception with description "Failed to initialize event: provided event_type 1 is not supported by rmw_zenoh_cpp, at /home/ahcorde/ros2_rolling/src/ros2/rmw_zenoh/rmw_zenoh_cpp/src/rmw_event.cpp:108" thrown in the test body.

test_wait_for_message (rclcpp)

segfault

rclcpp/rclcpp/test/rclcpp/test_wait_for_message.cpp:66

  auto wait = std::async(
    [&]() {
      auto ret = rclcpp::wait_for_message(out, node, "wait_for_message_topic" /*, -1 */);
      EXPECT_TRUE(ret);
      received = true;
    });

test_qos

67: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_qos.cpp:249: Failure
67: Expected equality of these values:
67:   ret.compatibility
67:     Which is: 4-byte object <00-00 00-00>
67:   rclcpp::QoSCompatibility::Error
67:     Which is: 4-byte object <02-00 00-00>
67: 
67: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_qos.cpp:250: Failure
67: Value of: ret.reason.empty()
67:   Actual: true
67: Expected: false
67: 
67: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_qos.cpp:258: Failure
67: Expected equality of these values:
67:   ret.compatibility
67:     Which is: 4-byte object <00-00 00-00>
67:   rclcpp::QoSCompatibility::Warning
67:     Which is: 4-byte object <01-00 00-00>

test_publisher (rclcpp)

62: [ RUN      ] TestPublisher.run_event_handlers
62: [ERROR] [1727446457.693761159] [rclcpp]: Couldn't take event info: rmw_take_event called when event queue for event type [9] is empty, at /home/ahcorde/ros2_rolling/src/ros2/rmw_zenoh/rmw_zenoh_cpp/src/rmw_event.cpp:204, at /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/src/rcl/event.c:175
62: unknown file: Failure
62: C++ exception with description "'data' is empty" thrown in the test body.

test_parameter_client (rclcpp)

56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:225: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)
56: 
56: [  FAILED  ] TestParameterClient.async_parameter_get_parameter_types (154 ms)
56: [ RUN      ] TestParameterClient.async_parameter_get_parameter_types_allow_undeclared
[Processing: rclcpp]                           
56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:249: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)
56: 
56: [  FAILED  ] TestParameterClient.async_parameter_get_parameter_types_allow_undeclared (179 ms)
56: [ RUN      ] TestParameterClient.async_parameter_get_parameters
56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:271: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)
56: 
56: [  FAILED  ] TestParameterClient.async_parameter_get_parameters (184 ms)
56: [ RUN      ] TestParameterClient.async_parameter_get_parameters_allow_undeclared
56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:293: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)
56: 
56: [  FAILED  ] TestParameterClient.async_parameter_get_parameters_allow_undeclared (188 ms)
56: [ RUN      ] TestParameterClient.async_parameter_set_parameters_atomically
56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:319: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)
56: 
56: [  FAILED  ] TestParameterClient.async_parameter_set_parameters_atomically (195 ms)
56: [ RUN      ] TestParameterClient.async_parameter_list_parameters
56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:341: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)

test_node_interfaces__node_graph (rclcpp)

44: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/node_interfaces/test_node_graph.cpp:645: Failure
44: Value of: endpoint_gid_is_all_zeros
44:   Actual: true
44: Expected: false

test_intra_process_manager (rclcpp)

33: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_intra_process_manager.cpp:500: Failure
33: Expected equality of these values:
33:   1u
33:     Which is: 1
33:   p1_subs
33:     Which is: 2

test_graph__rmw_zenoh_cpp (rcl)

## 98: [ RUN      ] NodeGraphMultiNodeFixture.test_node_info_subscriptions
98: [INFO] [1727443659.794092209] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443659.904155956] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443660.014433695] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/test/rcl/test_graph.cpp:1067: Failure
98: Expected: (attempts) <= (max_attempts), actual: 11 vs 10
98: Unable to attain all required nodes
98: 
98: [  FAILED  ] NodeGraphMultiNodeFixture.test_node_info_subscriptions (11335 ms)
98: [ RUN      ] NodeGraphMultiNodeFixture.test_node_info_publishers
98: [INFO] [1727443671.129462597] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443671.239459961] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443671.349025268] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
[Processing: rcl]                   
98: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/test/rcl/test_graph.cpp:1067: Failure
98: Expected: (attempts) <= (max_attempts), actual: 11 vs 10
98: Unable to attain all required nodes
98: 
98: [  FAILED  ] NodeGraphMultiNodeFixture.test_node_info_publishers (11333 ms)
98: [ RUN      ] NodeGraphMultiNodeFixture.test_node_info_services
98: [INFO] [1727443682.462878296] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443682.573755535] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443682.685009797] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/test/rcl/test_graph.cpp:1067: Failure
98: Expected: (attempts) <= (max_attempts), actual: 11 vs 10
98: Unable to attain all required nodes
98: 
98: [  FAILED  ] NodeGraphMultiNodeFixture.test_node_info_services (11335 ms)
98: [ RUN      ] NodeGraphMultiNodeFixture.test_node_info_clients
98: [INFO] [1727443693.798310426] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443693.908402327] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443694.018363041] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/test/rcl/test_graph.cpp:1067: Failure
98: Expected: (attempts) <= (max_attempts), actual: 11 vs 10
98: Unable to attain all required nodes

test_action_interaction__rmw_zenoh_cpp

11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:561: Failure
11: Expected equality of these values:
11:   ret
11:     Which is: 2
11:   0
11: error not set
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:573: Failure
11: Value of: this->is_status_ready
11:   Actual: false
11: Expected: true
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:581: Failure
11: Expected equality of these values:
11:   ret
11:     Which is: 4103
11:   0
11: error not set
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:584: Failure
11: Expected equality of these values:
11:   status_array.msg.status_list.size
11:     Which is: 1
11:   incoming_status_array.status_list.size
11:     Which is: 0

test_graph__rmw_zenoh_cpp (rcl_action)

13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.test_action_get_names_and_types (5333 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.test_action_get_server_names_and_types_by_node
13: [INFO] [1727443806.650512802] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443806.761221554] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443806.871264871] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.test_action_get_server_names_and_types_by_node (5333 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.test_action_get_client_names_and_types_by_node
13: [INFO] [1727443811.983360414] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443812.093825005] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443812.203928627] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.test_action_get_client_names_and_types_by_node (5332 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.get_names_and_types_maybe_fail
13: [INFO] [1727443817.315966907] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443817.428000517] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443817.537953229] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
[Processing: rcl_action]                   
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.get_names_and_types_maybe_fail (5334 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.action_client_init_maybe_fail
13: [INFO] [1727443822.650237406] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443822.760814004] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443822.870295696] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.action_client_init_maybe_fail (5378 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.rcl_get_client_names_and_types_by_node_maybe_fail
13: [INFO] [1727443828.031448905] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443828.145644359] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443828.256353051] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.rcl_get_client_names_and_types_by_node_maybe_fail (5339 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.rcl_get_server_names_and_types_by_node_maybe_fail
13: [INFO] [1727443833.367802389] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443833.480293497] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443833.590140755] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes

test_server

2: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp_action/test/test_server.cpp:1223: Failure
2: Expected equality of these values:
2:   "cancel request future timed out"
2:   e.what()
2:     Which is: "send goal future timed out"

@ahcorde
Copy link
Contributor

ahcorde commented Sep 30, 2024

rmw_zenoh/dev/1.0.0

  • rmw_zenoh commit: * rmw_zenoh commit: 63530b7
ROS Package Failing test name Failing test output
rcl test_graph__rmw_zenoh_cpp description below
rcl_action test_action_communication__rmw_zenoh_cpp description below
rcl_action test_graph__rmw_zenoh_cpp description below
rcl_action test_action_server timeout
rcl_lifecyle test_rcl_lifecycle Timeout
rcl_yaml_param_parser None description below
rclcpp test_allocator_memory_strategy timeout
rclcpp test_clock flaky
rclcpp test_intra_process_manager description below
rclcpp test_node_interfaces__node_graph description below
rclcpp test_parameter_client description below
rclcpp test_publisher description below
rclcpp test_qos description below
rclcpp test_wait_for_message description below
rclcpp test_events_executor timeout
rclcpp test_wait_set description below
rclcpp_action test_client timeout
rclcpp_action test_server timeout

test_action_communication (rcl_action)

11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:561: Failure
11: Expected equality of these values:
11:   ret
11:     Which is: 2
11:   0
11: error not set
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:573: Failure
11: Value of: this->is_status_ready
11:   Actual: false
11: Expected: true
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:581: Failure
11: Expected equality of these values:
11:   ret
11:     Which is: 4103
11:   0
11: error not set
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:584: Failure
11: Expected equality of these values:
11:   status_array.msg.status_list.size
11:     Which is: 1
11:   incoming_status_array.status_list.size
11:     Which is: 0

test_wait_set (rclcpp)

108: [ RUN      ] TestWaitSet.add_guard_condition_to_two_different_wait_set
108: unknown file: Failure
108: C++ exception with description "Failed to initialize event: provided event_type 7 is not supported by rmw_zenoh_cpp, at /home/ahcorde/ros2_rolling/src/ros2/rmw_zenoh/rmw_zenoh_cpp/src/rmw_event.cpp:53" thrown in the test body.
108: 
108: [  FAILED  ] TestWaitSet.add_guard_condition_to_two_different_wait_set (16 ms)
108: [ RUN      ] TestWaitSet.add_remove_wait
108: unknown file: Failure
108: C++ exception with description "Failed to initialize event: provided event_type 1 is not supported by rmw_zenoh_cpp, at /home/ahcorde/ros2_rolling/src/ros2/rmw_zenoh/rmw_zenoh_cpp/src/rmw_event.cpp:108" thrown in the test body.

test_wait_for_message (rclcpp)

segfault

rclcpp/rclcpp/test/rclcpp/test_wait_for_message.cpp:66

  auto wait = std::async(
    [&]() {
      auto ret = rclcpp::wait_for_message(out, node, "wait_for_message_topic" /*, -1 */);
      EXPECT_TRUE(ret);
      received = true;
    });

test_qos

67: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_qos.cpp:249: Failure
67: Expected equality of these values:
67:   ret.compatibility
67:     Which is: 4-byte object <00-00 00-00>
67:   rclcpp::QoSCompatibility::Error
67:     Which is: 4-byte object <02-00 00-00>
67: 
67: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_qos.cpp:250: Failure
67: Value of: ret.reason.empty()
67:   Actual: true
67: Expected: false
67: 
67: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_qos.cpp:258: Failure
67: Expected equality of these values:
67:   ret.compatibility
67:     Which is: 4-byte object <00-00 00-00>
67:   rclcpp::QoSCompatibility::Warning
67:     Which is: 4-byte object <01-00 00-00>

test_publisher (rclcpp)

62: [ RUN      ] TestPublisher.run_event_handlers
62: [ERROR] [1727446457.693761159] [rclcpp]: Couldn't take event info: rmw_take_event called when event queue for event type [9] is empty, at /home/ahcorde/ros2_rolling/src/ros2/rmw_zenoh/rmw_zenoh_cpp/src/rmw_event.cpp:204, at /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/src/rcl/event.c:175
62: unknown file: Failure
62: C++ exception with description "'data' is empty" thrown in the test body.

test_parameter_client (rclcpp)

56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:225: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)
56: 
56: [  FAILED  ] TestParameterClient.async_parameter_get_parameter_types (154 ms)
56: [ RUN      ] TestParameterClient.async_parameter_get_parameter_types_allow_undeclared
[Processing: rclcpp]                           
56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:249: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)
56: 
56: [  FAILED  ] TestParameterClient.async_parameter_get_parameter_types_allow_undeclared (179 ms)
56: [ RUN      ] TestParameterClient.async_parameter_get_parameters
56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:271: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)
56: 
56: [  FAILED  ] TestParameterClient.async_parameter_get_parameters (184 ms)
56: [ RUN      ] TestParameterClient.async_parameter_get_parameters_allow_undeclared
56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:293: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)
56: 
56: [  FAILED  ] TestParameterClient.async_parameter_get_parameters_allow_undeclared (188 ms)
56: [ RUN      ] TestParameterClient.async_parameter_set_parameters_atomically
56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:319: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)
56: 
56: [  FAILED  ] TestParameterClient.async_parameter_set_parameters_atomically (195 ms)
56: [ RUN      ] TestParameterClient.async_parameter_list_parameters
56: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_parameter_client.cpp:341: Failure
56: Expected equality of these values:
56:   rclcpp::FutureReturnCode::SUCCESS
56:     Which is: SUCCESS (0)
56:   return_code
56:     Which is: TIMEOUT (2)

test_node_interfaces__node_graph (rclcpp)

44: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/node_interfaces/test_node_graph.cpp:645: Failure
44: Value of: endpoint_gid_is_all_zeros
44:   Actual: true
44: Expected: false

test_intra_process_manager (rclcpp)

33: /home/ahcorde/ros2_rolling/src/ros2/rclcpp/rclcpp/test/rclcpp/test_intra_process_manager.cpp:500: Failure
33: Expected equality of these values:
33:   1u
33:     Which is: 1
33:   p1_subs
33:     Which is: 2

test_graph__rmw_zenoh_cpp (rcl)

## 98: [ RUN      ] NodeGraphMultiNodeFixture.test_node_info_subscriptions
98: [INFO] [1727443659.794092209] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443659.904155956] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443660.014433695] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/test/rcl/test_graph.cpp:1067: Failure
98: Expected: (attempts) <= (max_attempts), actual: 11 vs 10
98: Unable to attain all required nodes
98: 
98: [  FAILED  ] NodeGraphMultiNodeFixture.test_node_info_subscriptions (11335 ms)
98: [ RUN      ] NodeGraphMultiNodeFixture.test_node_info_publishers
98: [INFO] [1727443671.129462597] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443671.239459961] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443671.349025268] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
[Processing: rcl]                   
98: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/test/rcl/test_graph.cpp:1067: Failure
98: Expected: (attempts) <= (max_attempts), actual: 11 vs 10
98: Unable to attain all required nodes
98: 
98: [  FAILED  ] NodeGraphMultiNodeFixture.test_node_info_publishers (11333 ms)
98: [ RUN      ] NodeGraphMultiNodeFixture.test_node_info_services
98: [INFO] [1727443682.462878296] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443682.573755535] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443682.685009797] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/test/rcl/test_graph.cpp:1067: Failure
98: Expected: (attempts) <= (max_attempts), actual: 11 vs 10
98: Unable to attain all required nodes
98: 
98: [  FAILED  ] NodeGraphMultiNodeFixture.test_node_info_services (11335 ms)
98: [ RUN      ] NodeGraphMultiNodeFixture.test_node_info_clients
98: [INFO] [1727443693.798310426] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443693.908402327] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: [INFO] [1727443694.018363041] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
98: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl/test/rcl/test_graph.cpp:1067: Failure
98: Expected: (attempts) <= (max_attempts), actual: 11 vs 10
98: Unable to attain all required nodes

test_action_interaction__rmw_zenoh_cpp

11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:561: Failure
11: Expected equality of these values:
11:   ret
11:     Which is: 2
11:   0
11: error not set
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:573: Failure
11: Value of: this->is_status_ready
11:   Actual: false
11: Expected: true
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:581: Failure
11: Expected equality of these values:
11:   ret
11:     Which is: 4103
11:   0
11: error not set
11: 
11: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_action_communication.cpp:584: Failure
11: Expected equality of these values:
11:   status_array.msg.status_list.size
11:     Which is: 1
11:   incoming_status_array.status_list.size
11:     Which is: 0

test_graph__rmw_zenoh_cpp (rcl_action)

13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.test_action_get_names_and_types (5333 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.test_action_get_server_names_and_types_by_node
13: [INFO] [1727443806.650512802] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443806.761221554] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443806.871264871] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.test_action_get_server_names_and_types_by_node (5333 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.test_action_get_client_names_and_types_by_node
13: [INFO] [1727443811.983360414] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443812.093825005] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443812.203928627] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.test_action_get_client_names_and_types_by_node (5332 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.get_names_and_types_maybe_fail
13: [INFO] [1727443817.315966907] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443817.428000517] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443817.537953229] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
[Processing: rcl_action]                   
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.get_names_and_types_maybe_fail (5334 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.action_client_init_maybe_fail
13: [INFO] [1727443822.650237406] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443822.760814004] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443822.870295696] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.action_client_init_maybe_fail (5378 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.rcl_get_client_names_and_types_by_node_maybe_fail
13: [INFO] [1727443828.031448905] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443828.145644359] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443828.256353051] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes
13: 
13: [  FAILED  ] TestActionGraphMultiNodeFixture.rcl_get_client_names_and_types_by_node_maybe_fail (5339 ms)
13: [ RUN      ] TestActionGraphMultiNodeFixture.rcl_get_server_names_and_types_by_node_maybe_fail
13: [INFO] [1727443833.367802389] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443833.480293497] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: [INFO] [1727443833.590140755] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id ffa65399a158d8ccd21b64105f6c7af4.
13: /home/ahcorde/ros2_rolling/src/ros2/rcl/rcl_action/test/rcl_action/test_graph.cpp:347: Failure
13: Expected: (attempts) <= (max_attempts), actual: 5 vs 4
13: Unable to attain all required nodes

@YuanYuYuan
Copy link
Contributor

The failures of test_graph should be resolved once the RCL changes the logic in this PR.

@Yadunund
Copy link
Member Author

Yadunund commented Oct 1, 2024

@ahcorde can we update the ros2.repos file in https://github.com/yadunund/ros2 with the latest commits in rclcpp/rcl and re-run tests for both rolling and dev/1.0.0?

@ahcorde
Copy link
Contributor

ahcorde commented Oct 1, 2024

@ahcorde can we update the ros2.repos file in https://github.com/yadunund/ros2 with the latest commits in rclcpp/rcl and re-run tests for both rolling and dev/1.0.0?

There are some conflicts in the 1.0.0 branch #276 I will start with the 0.11 and when conflicts are resolved I will launch 1.0.0

@ahcorde
Copy link
Contributor

ahcorde commented Oct 2, 2024 •
edited
Loading

Test setup

rmw_zenoh/rolling

ROS Package Failing test name Failing test output
rcl None
rcl_action None
rcl_lifecyle test_rcl_lifecycle segfault
rcl_yaml_param_parser None
rclcpp test_intra_process_manager description below
rclcpp test_node_interfaces__node_graph description below
rclcpp test_publisher description below
rclcpp test_qos PR ros2/rclcpp#2639
rclcpp test_events_executor Timeout
rclcpp test_wait_set description below
rclcpp_action None
rclcpp_lifecycle None
rclcpp_components None
test_rclcpp None

@Yadunund There is a new regression on rcl_lifecycle. A segfault in this test test_rcl_lifecycle

rmw_zenoh/dev/1.0.0

ROS Package Failing test name Failing test output
rcl test_publisher__rmw_zenoh_cpp

There is an issue with zc_liveliness_token_check in the dev/1.0.0 branch

@ahcorde
Copy link
Contributor

ahcorde commented Oct 2, 2024

PR to fix rclcpp.test_qos ros2/rclcpp#2639

@diogomatsubara diogomatsubara mentioned this issue Oct 2, 2024
Closed
@Yadunund
Copy link
Member Author

Yadunund commented Oct 2, 2024 •
edited
Loading

@ahcorde thanks for reporting the regression. I can reproduce it. seems to be have caused by #278.


  'Unable to allocate space for type hash string., at /home/yadunund/ros2_rolling/src/ros2/rosidl/rosidl_runtime_c/src/type_hash.c:66'

with this new error message:

  'Failed to allocate type_hash_c_str., at /home/yadunund/ros2_rolling/src/ros2/rmw_zenoh/rmw_zenoh_cpp/src/detail/rmw_publisher_data.cpp:76'

@clalancette
Copy link
Collaborator

@ahcorde thanks for reporting the regression. I can reproduce it. seems to be have caused by #278.

Yes. Looking at it, the problem is that PublisherData::make can create a "partially-initialized" PublisherData object. Basically it can create the object, and then something further down can fail. At that point, the destructor for PublisherData will be called, at which point it will try to do shutdown(). Since shutdown() expects a fully-initialized object, it can access invalid memory.

One way to solve this would be to not actually create the PublisherData object until we have already initialized everything. That is, we would initialize everything into stack variables, and then do something like:

return std::make_shared<PublisherData>(node, gid, type_support_impl, type_support, entity, pub_cache, pub, token, events_mgr);

@Yadunund Yadunund mentioned this issue Oct 2, 2024
Merged
@YuanYuYuan
Copy link
Contributor

YuanYuYuan commented Oct 3, 2024 •
edited
Loading

There is a mistake in dev/1.0.0 which has been fixed in this commit. Now it can pass all the rcl_action tests.

100% tests passed, 0 tests failed out of 22

Label Time Summary:
copyright     =   1.32 sec*proc (1 test)
cppcheck      =   0.26 sec*proc (1 test)
cpplint       =   2.40 sec*proc (1 test)
gtest         =  65.53 sec*proc (16 tests)
lint_cmake    =   0.27 sec*proc (1 test)
linter        =   6.41 sec*proc (6 tests)
uncrustify    =   0.81 sec*proc (1 test)
xmllint       =   1.35 sec*proc (1 test)

Total Test time (real) =  71.95 sec
---
Finished <<< rcl_action [1min 12s]

Summary: 1 package finished [1min 13s]

@imstevenpmwork
Copy link
Contributor

imstevenpmwork commented Oct 3, 2024 •
edited by ahcorde
Loading

Hello guys, here's the latest update of the week.

Test Setup

Version

Logs

rolling rmw_zenoh: logs_system_test_rolling.zip
dev/1.0.0 rmw_zenoh: logs_system_test_dev100.zip

rmw_zenoh/rolling

ROS Package Failing test name Failing test output
rcl None None
rcl_action None None
rcl_lifecycle None None
rcl_yaml_param None None
rclcpp test_intra_process_manager Failed (Check logs)
rclcpp test_node_interfaces__node_graph Failed (Check logs)
rclcpp test_publisher Failed (Check logs)
rclcpp test_events_executor Timeout (Check logs)
rclcpp test_wait_set Failed (Check logs)
rclcpp_action test_client Failed (Check logs)
rclcpp_components None None
rclcpp_lifecycle test_lifecycle_node Failed (Check logs)
rmw_zenoh_cpp None None
test_cli None None
test_cli_remap test_cli_remapping TBD
test_communication test_requester_replier__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_action_client_server__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_requester_replier__rclcpp__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_action_client_server__rclcpp__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_qos test_deadline__rmw_zenoh_cpp Failed (Check logs)
test_qos test_liveliness__rmw_zenoh_cpp Failed (Check logs)
test_qos test_best_available__rmw_zenoh_cpp Failed (Check logs)
test_rclcpp None None
test_security None None

Nav2 Demo: Working

rmw_zenoh/dev/1.0.0

ROS Package Failing test name Failing test output
rcl None None
rcl_action test_graph__rmw_zenoh_cpp Timeout (Check logs)
rcl_lifecycle None None
rcl_yaml_param None None
rclcpp test_intra_process_manager Failed (Check logs)
rclcpp test_node_interfaces__node_graph Failed (Check logs)
rclcpp test_publisher Failed (Check logs)
rclcpp test_publisher_subscription_count_api Timeout (Check logs)
rclcpp test_wait_for_message Failed (Check logs)
rclcpp test_events_executor Timeout (Check logs)
rclcpp test_wait_set Failed (Check logs)
rclcpp_action None None
rclcpp_components test_component_manager Failed (Check logs)
rclcpp_lifecycle test_lifecycle_node Failed (Check logs)
rclcpp_lifecycle test_lifecycle_service_client Timeout (Check logs)
rmw_zenoh_cpp None None
test_cli None None
test_cli_remap test_cli_remapping Failed (Check logs)
test_communication test_requester_replier__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_action_client_server__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_requester_replier__rclcpp__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_action_client_server__rclcpp__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_publisher_subscriber__rclcpp__rmw_zenoh_cpp Failed (Check logs)
test_qos test_deadline__rmw_zenoh_cpp Failed (Check logs)
test_qos test_liveliness__rmw_zenoh_cpp Failed (Check logs)
test_qos test_best_available__rmw_zenoh_cpp Failed (Check logs)
test_rclcpp test_services_cpp__rmw_zenoh_cpp Timeout (Check logs)
test_rclcpp test_services_cpp__rmw_zenoh_cpp Failed (Check logs)
test_security None None

Nav2 Demo: Not Working

Summary

rmw_zenoh/rolling: 15 failing tests
rmw_zenoh/dev/1.0.0: 22 failing tests
Delta: 7 tests
Note: mind some of them might/are flaky

@YuanYuYuan
Copy link
Contributor

YuanYuYuan commented Oct 3, 2024 •
edited
Loading

The reason that 1.0 is failing in rcl/test_wait_for_message is we try to fetch the z_id info of the session while creating a subscription AFTER the shutdown is called. Since the session is not alive anymore, it would cause a segfault.

After a discussion with the team, it's impossible to check the session status once it's dropped. The design is elegant in Rust that users can't even use the session object once the session is dead. In rmw_zenoh, We had better follow the same way and wrap the session with a smart pointer. We expect this will be better handled once we migrate to zenoh-cpp.

@Yadunund
Copy link
Member Author

Yadunund commented Oct 3, 2024

@imstevenpmwork can you retry the tests with Rolling built from source using the latest ros2.repos from here?

@ahcorde
Copy link
Contributor

ahcorde commented Oct 4, 2024

This PR should fix test_events_executor in rclcpp

@ahcorde
Copy link
Contributor

ahcorde commented Oct 4, 2024

This PR should fix some of the failures in test_communication

@ahcorde
Copy link
Contributor

ahcorde commented Oct 4, 2024 •
edited
Loading

This PR should fix test_deadline__rmw_zenoh_cpp and test_liveliness__rmw_zenoh_cpp

@ahcorde ahcorde mentioned this issue Oct 4, 2024
Closed
@ahcorde
Copy link
Contributor

ahcorde commented Oct 4, 2024

This PR should fix test_cli_remapping

@ahcorde
Copy link
Contributor

ahcorde commented Oct 4, 2024

This PR should fix test_wait_set in rclcpp

@ahcorde ahcorde mentioned this issue Oct 4, 2024
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Oct 4, 2024

I found some issue on rclpy this PR should fix then

@ahcorde
Copy link
Contributor

ahcorde commented Oct 8, 2024

ros2.repos

rmw_zenoh/dev/1.0.0

ROS Package Failing test name Failing test output
rcl None None
rcl_action test_graph__rmw_zenoh_cpp Timeout (Check logs)
rcl_lifecycle None None
rcl_yaml_param None None
rclcpp test_intra_process_manager Failed (Check logs)
rclcpp test_node_interfaces__node_graph Failed (Check logs)
rclcpp test_parameter_client Failed (Check logs)
rclcpp test_publisher Failed (Check logs)
rclcpp test_events_executor Timeout (Check logs)
rclcpp test_wait_set Failed (Check logs)
rclcpp_action test_server
rclcpp_components test_component_manager Failed (Check logs)
rclcpp_lifecycle test_lifecycle_node Failed (Check logs)
rclcpp_lifecycle test_lifecycle_service_client Timeout (Check logs)
rmw_zenoh_cpp None None
test_cli None None
test_cli_remap test_cli_remapping Failed (Check logs)

test_parameter_client is a new failure

@imstevenpmwork
Copy link
Contributor

imstevenpmwork commented Oct 10, 2024 •
edited
Loading

Hello guys, here's the latest update of the week.

Test Setup

Version

Logs

rolling rmw_zenoh: TBD
dev/1.0.0 rmw_zenoh: TBD

rmw_zenoh/rolling

ROS Package Failing test name Failing test output
rcl None None
rcl_action None None
rcl_lifecycle None None
rcl_yaml_param None None
rclcpp test_intra_process_manager Failed (Check logs)
rclcpp test_node_interfaces__node_graph Failed (Check logs)
rclcpp test_publisher Failed (Check logs)
rclcpp test_events_executor Timeout (Check logs)
rclcpp_action None None
rclcpp_components None None
rclcpp_lifecycle test_lifecycle_node Failed (Check logs)
rmw_zenoh_cpp None None
test_cli None None
test_cli_remap test_cli_remapping Failed (Check logs)
test_communication test_requester_replier__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_action_client_server__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_requester_replier__rclcpp__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_action_client_server__rclcpp__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_qos test_deadline__rmw_zenoh_cpp Failed (Check logs)
test_qos test_liveliness__rmw_zenoh_cpp Failed (Check logs)
test_qos test_best_available__rmw_zenoh_cpp Failed (Check logs)
test_rclcpp None None
test_security None None

Nav2 Demo: Working

rmw_zenoh/dev/1.0.0

ROS Package Failing test name Failing test output
rcl None None
rcl_action None None
rcl_lifecycle None None
rcl_yaml_param None None
rclcpp test_intra_process_manager Failed (Check logs)
rclcpp test_node_interfaces__node_graph Failed (Check logs)
rclcpp test_publisher Failed (Check logs)
rclcpp test_executors_timer_cancel_behavior Timeout (Check logs)
rclcpp test_events_executor Timeout (Check logs)
rclcpp test_executor Timeout (Check logs)
rclcpp_action test_client Timeout (Check logs)
rclcpp_components None None
rclcpp_lifecycle test_lifecycle_node Failed (Check logs)
rclcpp_lifecycle test_lifecycle_service_client Timeout (Check logs)
rmw_zenoh_cpp cpplint Failed (Check logs)
rmw_zenoh_cpp uncrustify Failed (Check logs)
test_cli None None
test_cli_remap test_cli_remapping Failed (Check logs)
test_communication test_requester_replier__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_action_client_server__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_requester_replier__rclcpp__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_action_client_server__rclcpp__rclpy__rmw_zenoh_cpp Failed (Check logs)
test_communication test_publisher_subscriber__rclcpp__rmw_zenoh_cpp Failed (Check logs)
test_qos test_deadline__rmw_zenoh_cpp Failed (Check logs)
test_qos test_liveliness__rmw_zenoh_cpp Failed (Check logs)
test_qos test_best_available__rmw_zenoh_cpp Failed (Check logs)
test_rclcpp gtest_spin__rmw_zenoh_cpp Failed (Check logs)
test_rclcpp test_n_nodes__rmw_zenoh_cpp Failed (Check logs)
test_rclcpp test_node_name__rmw_zenoh_cpp Timeout (Check logs)
test_security None None

Nav2 Demo: Not working

Summary

rmw_zenoh/rolling: 13 failing tests (-2 change)
rmw_zenoh/dev/1.0.0: 22 failing tests (0 change, but 2 are format)
Delta: 9 tests
Note: mind some of them might/are flaky so the precise count may not be accurate

@ahcorde
Copy link
Contributor

ahcorde commented Oct 31, 2024 •
edited
Loading

Windows

rmw_zenoh/dev/1.0.0

ROS Package Failing test name Failing test output
rcl test_timer__rmw_zenoh_cpp None
rcl test_arguments None
rcl test_secutiry None
rcl_action test_graph__rmw_zenoh_cpp Timeout (Check logs)
rcl_lifecycle None None
rcl_yaml_param_parser None None
rclcpp test_generic_client
rclcpp test_generic_service
rclcpp test_client_common
rclcpp test_node
rclcpp test_publisher
rclcpp test_typesupport_helpers
rclcpp test_executors Failed (Check logs)
rclcpp test_executor Failed (Check logs)
rclcpp test_generic_pubsub__rmw_zenoh_cpp Failed (Check logs)
rclcpp_action None
rclcpp_lifecycle None Failed (Check logs)
rmw_zenoh_cpp None None

@Yadunund
Copy link
Member Author

@ahcorde did you get a chance to run the tests on Windows with the rolling branch?

@YuanYuYuan
Copy link
Contributor

YuanYuYuan commented Nov 4, 2024 •
edited
Loading

System Test

Pacakge Test Reason
test_cli_remapping 1 - test_cli_remapping (Failed) Will be fixed by upstream
test_quality_of_service 9 - test_deadline__rmw_zenoh_cpp (Failed) Will be skipped
test_quality_of_service 11 - test_liveliness__rmw_zenoh_cpp (Failed) Will be skipped
test_quality_of_service 12 - test_best_available__rmw_zenoh_cpp (Failed) Also failed in 0.11.0
rclcpp_lifecycle 6 - test_lifecycle_node (Failed) Hard to reproduce
rclcpp_lifecycle 9 - test_lifecycle_service_client (Timeout) Hard to reproduce
rclcpp_action 1 - test_client (Timeout) Hard to reproduce
test_communication 73 - test_publisher_subscriber__rclpy__rmw_zenoh_cpp (Failed) session closing deadlock
test_communication 76 - test_publisher_subscriber__rclpy__rclcpp__rmw_zenoh_cpp (Failed) session closing deadlock
test_communication 82 - test_publisher_subscriber__rclcpp__rmw_zenoh_cpp (Failed) session closing deadlock
test_communication 74 - test_requester_replier__rclpy__rmw_zenoh_cpp (Failed) Will be fixed by rclpy
test_communication 80 - test_requester_replier__rclcpp__rclpy__rmw_zenoh_cpp (Failed) Will be fixed by rclpy
test_rclcpp 57 - gtest_client_wait_for_service_shutdown__rmw_zenoh_cpp (Failed) Hard to reproduce
test_rclcpp 74 - test_n_nodes__rmw_zenoh_cpp (Failed) session closing deadlock
rclcpp 62 - test_publisher (Failed) Also failed in 0.11.0
rclcpp 118 - test_executor (Failed) Hard to reproduce

@ahcorde
Copy link
Contributor

ahcorde commented Nov 4, 2024

@ahcorde did you get a chance to run the tests on Windows with the rolling branch?

When I try to execute the rclcpp test my virtual machine just dead. I'm looking in to it, but rcl and rcl_action have more failing test

@Yadunund
Copy link
Member Author

Yadunund commented Nov 7, 2024

Maybe we just need to put existing information together but can we have a single follow-up comment in the format above where there are two tables (rolling vs dev/1.0.0) along with the ros2.repos file used to generate test results for both tables? Such a view would help provide a clear overview of the state of the two branches.

@ahcorde
Copy link
Contributor

ahcorde commented Nov 8, 2024

Windows

zenoh 1.0.0

rmw_zenoh/dev/1.0.0

ROS Package Failing test name Failing test output
rcl test_service__rmw_zenoh_cpp None
rcl_action test_graph__rmw_zenoh_cpp flaky
rcl_lifecycle None None
rcl_yaml_param_parser None None
rclcpp test_publisher
rclcpp_action None
rclcpp_lifecycle None Failed (Check logs)

@ahcorde
Copy link
Contributor

ahcorde commented Nov 8, 2024

ros2.repos

rmw_zenoh/dev/1.0.0

ROS Package Failing test name Failing test output
rcl None None
rcl_action test_graph__rmw_zenoh_cpp flaky
rcl_lifecycle None None
rcl_yaml_param None None
rclcpp test_publisher Failed (Check logs)
rclcpp test_events_executor Timeout (Check logs)
rclcpp_action test_server
rclcpp_components test_component_manager Failed (Check logs)
rclcpp_lifecycle test_lifecycle_node Failed (Check logs)
rclcpp_lifecycle test_lifecycle_service_client Timeout (Check logs)

clalancette/cleanup-rmw-context-impl

ROS Package Failing test name Failing test output
rcl None None
rcl_action None None
rcl_lifecycle None None
rcl_yaml_param None None
rclcpp test_publisher Failed (Check logs)
rclcpp test_events_executor Timeout (Check logs)
rclcpp_action None
rclcpp_components None
rclcpp_lifecycle None
rclcpp_lifecycle None None

This was referenced Nov 8, 2024
Merged
Merged
@YuanYuYuan
Copy link
Contributor

YuanYuYuan commented Nov 18, 2024 •
edited
Loading

Pacakge Test Reason
test_quality_of_service 9 - test_deadline__rmw_zenoh_cpp (Failed) Will be skipped
test_quality_of_service 11 - test_liveliness__rmw_zenoh_cpp (Failed) Will be skipped
test_quality_of_service 12 - test_best_available__rmw_zenoh_cpp (Failed) #316
rclcpp_lifecycle 6 - test_lifecycle_node (Failed) Flaky
test_communication 80 - test_requester_replier__rclcpp__rclpy__rmw_zenoh_cpp (Failed) Flaky
test_communication 81 - test_action_client_server__rclcpp__rclpy__rmw_zenoh_cpp (Failed) Flaky
test_rclcpp 70 - test_parameter_server_cpp__rmw_zenoh_cpp (Timeout) Flaky
rclcpp 62 - test_publisher (Failed) #317
rclcpp 86 - test_time (Failed) Flaky
rclcpp 118 - test_executor (Failed) Flaky
rclpy 3 - test_action_client (Failed) #315
  • Will be skipped means the test will be skipped from the upstream.
  • Flaky means it's hard to reproduce it on a local machine.
  • The issues are created since these tests are reproducible and fail on both dev/1.0.0 and rolling.

@clalancette
Copy link
Collaborator

While I know for sure that we aren't yet passing all tests, I think we are down to few enough that we should track them individually. Thus I'm going to close out this tracking bug, and instead opt for individual bug reports. Please feel free to reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@clalancette @ahcorde @YuanYuYuan @Yadunund @imstevenpmwork