Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weigh renaming action_msgs to action_interfaces #95

Closed
tfoote opened this issue Apr 2, 2020 · 1 comment
Closed

Weigh renaming action_msgs to action_interfaces #95

tfoote opened this issue Apr 2, 2020 · 1 comment
Assignees

Comments

@tfoote
Copy link
Contributor

tfoote commented Apr 2, 2020

This is a follow up to the Aggregate Foxy Message API Review

It was flagged that new packages are using the standard _interfaces while this is using the older standard _msgs.

We should trade off whether renaming it is more valuable or leaving things as they are is higher value.

@tfoote tfoote self-assigned this Apr 2, 2020
@tfoote
Copy link
Contributor Author

tfoote commented May 5, 2020

It would be more consistent to have made the new package follow the newer version of the conventions. However it's still following the old naming convention and that convention is well established and will not disappear soon so it's not going to be something that will be hard to understand.

Changing the name of this package will be disruptive and require changing any and all usages of the message. This is a significant distributed cost for a small mostly aesthetic cleanup. Because of that we should stick with the status quo and keep things as they are.

@tfoote tfoote closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant