Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation of ROS Time #94

Closed
tfoote opened this issue Apr 2, 2020 · 0 comments · Fixed by #103
Closed

Improve documentation of ROS Time #94

tfoote opened this issue Apr 2, 2020 · 0 comments · Fixed by #103
Assignees
@tfoote
Labels
documentation enhancement New feature or request

Comments

@tfoote
Copy link
Contributor

tfoote commented Apr 2, 2020

This is a follow up to the Aggregate Foxy Message API Review

From: https://github.com/ros2/common_interfaces/pull/86/files#r393329045

Improve documentation in the message to indicate that it's specifically a ROS time with time since epoch, or time since the start of simulation.

We could consider making a separate Steady time type that can support things like hardware timestamps. Potentially providing a UUID for identifying the epoch so that only times on the same epoch can be compared.
@tfoote tfoote self-assigned this Apr 2, 2020
tfoote added a commit that referenced this issue May 5, 2020
@tfoote
Document that Time and Duration are explictly ROS Time
4d9b596 
Fixes #94

Signed-off-by: Tully Foote <[email protected]>
This was referenced May 5, 2020
Merged
Open
@tfoote tfoote added documentation enhancement New feature or request labels May 5, 2020
tfoote added a commit that referenced this issue Jun 19, 2020
@tfoote
Document that Time and Duration are explictly ROS Time (#103)
5a4a3bd 
Fixes #94

Signed-off-by: Tully Foote <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfoote tfoote

Labels
documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document that Time and Duration are explictly ROS Time ros2/rcl_interfaces
1 participant
@tfoote