Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build unstable for dynamic array of static arrays #42

Closed
jacobperron opened this issue Oct 22, 2018 · 2 comments · Fixed by ros2/rosidl#307
Closed

Windows build unstable for dynamic array of static arrays #42

jacobperron opened this issue Oct 22, 2018 · 2 comments · Fixed by ros2/rosidl#307
Assignees
Labels
bug Something isn't working

Comments

@jacobperron
Copy link
Member

Bug report

Required Info:

Steps to reproduce issue

Test message:

StaticArrayPrimitives[] dynamic_array_static_array_primitive_values

Results in conversion warnings of the nature:

conversion from 'const int' to 'int8_t', possible loss of data

Windows Build Status


This affects #41

@jacobperron jacobperron added the bug Something isn't working label Oct 22, 2018
@jacobperron
Copy link
Member Author

Someone can correct me if I'm wrong, but I think the bug may be in rosidl_typesupport_connext_cpp and rosidl_typesupport_fastrtps_cpp.

@jacobperron jacobperron self-assigned this Oct 23, 2018
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Oct 23, 2018
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Oct 23, 2018
@jacobperron
Copy link
Member Author

For posterity, a detailed log of build warnings:

Partial log

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2888): warning C4244: '=': conversion from 'const int' to 'uint8_t', possible loss of data (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp) [C:\J\workspace\ci_windows\ws\build\test_msgs\test_msgs__rosidl_typesupport_connext_cpp.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2902): note: see reference to function template instantiation 'void std::_Fill_unchecked1<_FwdIt,_Ty>(_FwdIt,_FwdIt,const _Ty &,std::false_type)' being compiled
          with
          [
              _FwdIt=unsigned char *,
              _Ty=int
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  static_array_primitives__type_support.cpp
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2910): note: see reference to function template instantiation 'void std::_Fill_unchecked<unsigned char*,_Ty>(_FwdIt,_FwdIt,const _Ty &)' being compiled
          with
          [
              _Ty=int,
              _FwdIt=unsigned char *
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_generator_cpp\test_msgs/msg/static_array_primitives__struct.hpp(51): note: see reference to function template instantiation 'void std::fill<std::_Array_iterator<_Ty,3>,int>(_FwdIt,_FwdIt,const int &)' being compiled
          with
          [
              _Ty=uint8_t,
              _FwdIt=std::_Array_iterator<uint8_t,3>
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_generator_cpp\test_msgs/msg/static_array_primitives__struct.hpp(41): note: while compiling class template member function 'test_msgs::msg::StaticArrayPrimitives_<std::allocator<void>>::StaticArrayPrimitives_(rosidl_generator_cpp::MessageInitialization)' (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xmemory0(945): note: see reference to function template instantiation 'test_msgs::msg::StaticArrayPrimitives_<std::allocator<void>>::StaticArrayPrimitives_(rosidl_generator_cpp::MessageInitialization)' being compiled (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp(77): note: see reference to class template instantiation 'test_msgs::msg::StaticArrayPrimitives_<std::allocator<void>>' being compiled
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2888): warning C4244: '=': conversion from 'const int' to 'char', possible loss of data (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp) [C:\J\workspace\ci_windows\ws\build\test_msgs\test_msgs__rosidl_typesupport_connext_cpp.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2902): note: see reference to function template instantiation 'void std::_Fill_unchecked1<_FwdIt,_Ty>(_FwdIt,_FwdIt,const _Ty &,std::false_type)' being compiled
          with
          [
              _FwdIt=char *,
              _Ty=int
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2910): note: see reference to function template instantiation 'void std::_Fill_unchecked<char*,_Ty>(_FwdIt,_FwdIt,const _Ty &)' being compiled
          with
          [
              _Ty=int,
              _FwdIt=char *
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_generator_cpp\test_msgs/msg/static_array_primitives__struct.hpp(52): note: see reference to function template instantiation 'void std::fill<std::_Array_iterator<_Ty,3>,int>(_FwdIt,_FwdIt,const int &)' being compiled
          with
          [
              _Ty=char,
              _FwdIt=std::_Array_iterator<char,3>
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2888): warning C4244: '=': conversion from 'const int' to 'int8_t', possible loss of data (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp) [C:\J\workspace\ci_windows\ws\build\test_msgs\test_msgs__rosidl_typesupport_connext_cpp.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2902): note: see reference to function template instantiation 'void std::_Fill_unchecked1<_FwdIt,_Ty>(_FwdIt,_FwdIt,const _Ty &,std::false_type)' being compiled
          with
          [
              _FwdIt=signed char *,
              _Ty=int
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2910): note: see reference to function template instantiation 'void std::_Fill_unchecked<signed char*,_Ty>(_FwdIt,_FwdIt,const _Ty &)' being compiled
          with
          [
              _Ty=int,
              _FwdIt=signed char *
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_generator_cpp\test_msgs/msg/static_array_primitives__struct.hpp(67): note: see reference to function template instantiation 'void std::fill<std::_Array_iterator<_Ty,3>,int>(_FwdIt,_FwdIt,const int &)' being compiled
          with
          [
              _Ty=int8_t,
              _FwdIt=std::_Array_iterator<int8_t,3>
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2888): warning C4244: '=': conversion from 'const int' to 'int16_t', possible loss of data (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp) [C:\J\workspace\ci_windows\ws\build\test_msgs\test_msgs__rosidl_typesupport_connext_cpp.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2902): note: see reference to function template instantiation 'void std::_Fill_unchecked1<_FwdIt,_Ty>(_FwdIt,_FwdIt,const _Ty &,std::false_type)' being compiled
          with
          [
              _FwdIt=short *,
              _Ty=int
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2910): note: see reference to function template instantiation 'void std::_Fill_unchecked<short*,_Ty>(_FwdIt,_FwdIt,const _Ty &)' being compiled
          with
          [
              _Ty=int,
              _FwdIt=short *
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_generator_cpp\test_msgs/msg/static_array_primitives__struct.hpp(69): note: see reference to function template instantiation 'void std::fill<std::_Array_iterator<_Ty,3>,int>(_FwdIt,_FwdIt,const int &)' being compiled
          with
          [
              _Ty=int16_t,
              _FwdIt=std::_Array_iterator<int16_t,3>
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2888): warning C4244: '=': conversion from 'const int' to 'uint16_t', possible loss of data (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp) [C:\J\workspace\ci_windows\ws\build\test_msgs\test_msgs__rosidl_typesupport_connext_cpp.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2902): note: see reference to function template instantiation 'void std::_Fill_unchecked1<_FwdIt,_Ty>(_FwdIt,_FwdIt,const _Ty &,std::false_type)' being compiled
          with
          [
              _FwdIt=unsigned short *,
              _Ty=int
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\xutility(2910): note: see reference to function template instantiation 'void std::_Fill_unchecked<unsigned short*,_Ty>(_FwdIt,_FwdIt,const _Ty &)' being compiled
          with
          [
              _Ty=int,
              _FwdIt=unsigned short *
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)
  C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_generator_cpp\test_msgs/msg/static_array_primitives__struct.hpp(70): note: see reference to function template instantiation 'void std::fill<std::_Array_iterator<_Ty,3>,int>(_FwdIt,_FwdIt,const int &)' being compiled
          with
          [
              _Ty=uint16_t,
              _FwdIt=std::_Array_iterator<uint16_t,3>
          ] (compiling source file C:\J\workspace\ci_windows\ws\build\test_msgs\rosidl_typesupport_connext_cpp\test_msgs\msg\dds_connext\dynamic_array_static_array_primitives_nested__type_support.cpp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant