You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Comment: probability being 0-100 doesn't take advantage of all the bits the int8 type offers. 0-255 where 255 is 100% probability would have slightly better resolution.
The text was updated successfully, but these errors were encountered:
I would suggest that this change is too disruptive to be valuable. The message was designed to support both probabilities as well as special values like the -1 unknown value. Switching to a slightly higher precision would cause a lot of disruption. If there is a use case for needing higher precision then it would make sense to define another message with significantly higher precision, potentially something like 32bit floating point. But until there’s a need for that I would suggest not changing this message definition.
Due to the risk of breaking users logic we shouldn't make a subtle change like adjusting the range of expected values in the field. And not currently having a strong use case where the current values are inadequate I'm going to close this as it works for now. In the future to revisit this we should make a new datatype to replace this one for a more robust migration.
This is a follwup to the pre Foxy Message API review
The text was updated successfully, but these errors were encountered: