Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing OccupancyGrid to use probabilities on 0-255 instead of 0-100 #96

Closed
tfoote opened this issue Apr 7, 2020 · 2 comments

Comments

@tfoote
Copy link
Contributor

tfoote commented Apr 7, 2020

This is a follwup to the pre Foxy Message API review

Comment: probability being 0-100 doesn't take advantage of all the bits the int8 type offers. 0-255 where 255 is 100% probability would have slightly better resolution.

@tfoote
Copy link
Contributor Author

tfoote commented Apr 7, 2020

I would suggest that this change is too disruptive to be valuable. The message was designed to support both probabilities as well as special values like the -1 unknown value. Switching to a slightly higher precision would cause a lot of disruption. If there is a use case for needing higher precision then it would make sense to define another message with significantly higher precision, potentially something like 32bit floating point. But until there’s a need for that I would suggest not changing this message definition.

@tfoote
Copy link
Contributor Author

tfoote commented May 5, 2020

Due to the risk of breaking users logic we shouldn't make a subtle change like adjusting the range of expected values in the field. And not currently having a strong use case where the current values are inadequate I'm going to close this as it works for now. In the future to revisit this we should make a new datatype to replace this one for a more robust migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant