Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing DisparityImage header field #88

Closed
tfoote opened this issue Apr 2, 2020 · 1 comment
Closed

Consider removing DisparityImage header field #88

tfoote opened this issue Apr 2, 2020 · 1 comment
Labels

Comments

@tfoote
Copy link
Contributor

tfoote commented Apr 2, 2020

This is a follow up to the Aggregate Foxy Message API Review

The DisparityImage has a header that's documented as it will likely be removed in a future release.

# Separate header for compatibility with current TimeSynchronizer.
# Likely to be removed in a later release, use image.header instead.
std_msgs/Header header

Since that was several years ago are we ready to remove it now? The one question is whether the TimeSynchronizer can support introspecting into the internal image headers.

@hidmic hidmic added the backlog label Apr 9, 2020
@tfoote
Copy link
Contributor Author

tfoote commented May 15, 2020

Reviewing the useages of this message there's still a large fraction of the common use cases which leverage the message_fitler implementation which relies upon the root header. Removing that would break those use cases. And as such we should leave it be for now. The cost of the additional data is low compared to the size of the disparity data.

@tfoote tfoote closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants