Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate action message definitions #64

Open
nburek opened this issue Nov 14, 2018 · 1 comment
Open

Duplicate action message definitions #64

nburek opened this issue Nov 14, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@nburek
Copy link

nburek commented Nov 14, 2018

Feature request

Feature description

There actionlb_msgs defined in this repository appear to be a duplicate of the action_msgs defined in rcl_interfaces: https://github.com/ros2/rcl_interfaces/tree/master/action_msgs

It is confusing having both of these as it isn't clear which one should be used and may cause fragmentation going forward. If possible one of these should be deleted or at the very least renamed.

Implementation considerations

I assume that one of these is here for some historical reason. If there are dependency reasons that one of these cannot be deleted yet then it would be good to at least mark them as deprecated and document what should be used. If someone knows which of these should actually be kept going forward it would be nice to have that information added to this issue.

@sloretz
Copy link
Contributor

sloretz commented Nov 14, 2018

action_msgs will be used for ROS 2 actions. The only use case for actionlib_msgs I'm aware of is to bridge the ROS 1 action topics directly. I think it can be removed when the ROS 1 bridge supports actions.

@clalancette clalancette added the ready Work is about to start (Kanban column) label Nov 15, 2018
@cottsay cottsay added the enhancement New feature or request label Jan 24, 2019
@jacobperron jacobperron removed the ready Work is about to start (Kanban column) label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants