Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider changing sensor_msgs/Joy buttons to use bools #102

Closed
tfoote opened this issue Apr 8, 2020 · 1 comment
Closed

consider changing sensor_msgs/Joy buttons to use bools #102

tfoote opened this issue Apr 8, 2020 · 1 comment

Comments

@tfoote
Copy link
Contributor

tfoote commented Apr 8, 2020

This is a follwup to the pre Foxy Message API review

Buttons seem to be bools. Are there buttons which have different values? Will the bools make API easier? Will the bool reduce content on the wire?

https://github.com/ros2/common_interfaces/pull/86/files#r392501587
@tfoote
Copy link
Contributor Author

tfoote commented May 5, 2020

I confirmed that DualShock 2 and 3 both have pressure sensitive buttons. https://en.wikipedia.org/wiki/DualShock

Most of them were removed in Dualshock 4 but not all https://gizbuyerguide.com/are-playstation-4-buttons-pressure-sensitive/

Since we have positive examples we shouldn't remove the ability to support pressure sensitive buttons.

@tfoote tfoote closed this as completed May 5, 2020
@tfoote tfoote mentioned this issue May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tfoote