Remove support for copying repositories into the release org. (#45268)

This support was helpful to get started but creates problems with the
current terraform-managed ros2-gbp org and with encouraging split-brain
releases where some are made from external release repositories and some
are made from the official release org.

Before running the migration, check the source distribution for release
repository urls outside the release org and mirror them to the release
org before continuing.

The rosdistro-bloom rewrite of this script intends to support this
workflow with a separate subcommand for mirroring repos.

Author: nuclearsandwich

migration-tools/README.md

@@ -20,21 +20,17 @@ Make sure rosdep is initialized if it isn't already.
 
     sudo rosdep init
 
-Configure a GitHub access token and release repository organization.
-The token only needs public repository access and must belong to a member of the target GitHub organization with repository creation permissions.
-
-```
-GITHUB_TOKEN={token with public repository access}
-export GITHUB_TOKEN
-```
+This script used to copy release repositories into the release org as-needed.
+This worked for the initial bootstrapping but creates split-brain problems when releases are split between the official release org and others.
+Instead, use `git clone --mirror` and `git push --mirror` on release repositories that are not yet in the release org and update your rosdistro before running this script.
 
 ## Script arguments
 
 The migration script has several named arguments, all of which are required.
 * `--dest DEST_ROSDISTRO`: The rosdistro which will receive the newly bloomed repositories.
 * `--source SOURCE_ROSDISTRO`: The rosdistro to take release repositories from for migration.
 * `--source-ref GIT_COMMIT_ID_OR_REF`: The migration may be attempted multiple times. Each attempt must specify ref or commit to start from so that future changes to the source distribution do not unintentionally affect migration. This also enables platform migration without changing the rosdistro name.
-* `--release-org GITHUB_ORG`: A GitHub organization for storing release repositories. If the repository does not exist in this organization a new repository will be created.
+* `--release-org GITHUB_ORG`: A GitHub organization for storing release repositories.
 
 ## Features
 

migration-tools/migrate-rosdistro.py

@@ -49,10 +49,6 @@ def write_tracks_file(tracks, commit_msg=None):
 
 args = parser.parse_args()
 
-gclient = github.Github(os.environ['GITHUB_TOKEN'])
-release_org = gclient.get_organization(args.release_org)
-org_release_repos = [r.name for r in release_org.get_repos() if r.name]
-
 if not os.path.isfile('index-v4.yaml'):
     raise RuntimeError('This script must be run from a rosdistro index directory.')
 rosdistro_dir = os.path.abspath(os.getcwd())
@@ -134,6 +130,10 @@ def write_tracks_file(tracks, commit_msg=None):
         if release_spec.version is None:
             raise ValueError(f'{repo_name} is not released in the source distribution (release version is missing or blank).')
         remote_url = release_spec.url
+
+        if not remote_url.startswith(f'https://github.com/{args.release_org}/'):
+            raise ValueError(f'{remote_url} is not in the release org. Mirror the repository there to continue.')
+
         release_repo = remote_url.split('/')[-1]
         if release_repo.endswith('.git'):
             release_repo = release_repo[:-4]
@@ -144,13 +144,6 @@ def write_tracks_file(tracks, commit_msg=None):
         if not tracks['tracks'].get(args.source):
             raise ValueError('Repository has not been released.')
 
-        if release_repo not in org_release_repos:
-            release_org.create_repo(release_repo)
-        new_release_repo_url = f'https://github.com/{args.release_org}/{release_repo}.git'
-        subprocess.check_call(['git', 'remote', 'rename', 'origin', 'oldorigin'])
-        subprocess.check_call(['git', 'remote', 'set-url', '--push', 'oldorigin', 'no_push'])
-        subprocess.check_call(['git', 'remote', 'add', 'origin', new_release_repo_url])
-
         if args.source != args.dest:
             # Copy a bloom .ignored file from source to target distro.
             if os.path.isfile(f'{args.source}.ignored'):
@@ -164,7 +157,7 @@ def write_tracks_file(tracks, commit_msg=None):
             dest_track = copy.deepcopy(tracks['tracks'][args.source])
             dest_track['ros_distro'] = args.dest
             tracks['tracks'][args.dest] = dest_track
-            ls_remote = subprocess.check_output(['git', 'ls-remote', '--heads', 'oldorigin', f'*{args.source}*'], universal_newlines=True)
+            ls_remote = subprocess.check_output(['git', 'ls-remote', '--heads', 'origin', f'*{args.source}*'], universal_newlines=True)
             for line in ls_remote.split('\n'):
                 if line == '':
                     continue
@@ -218,8 +211,6 @@ def write_tracks_file(tracks, commit_msg=None):
         # currently in the release track.
         release_inc = str(max(int(source_inc), int(dest_track['release_inc'])) + 1)
 
-        # Bloom will not run with multiple remotes.
-        subprocess.check_call(['git', 'remote', 'remove', 'oldorigin'])
         subprocess.check_call(['git', 'bloom-release', '--non-interactive', '--release-increment', release_inc, '--unsafe', args.dest], stdin=subprocess.DEVNULL, env=os.environ)
         subprocess.check_call(['git', 'push', 'origin', '--all', '--force'])
         subprocess.check_call(['git', 'push', 'origin', '--tags', '--force'])