-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<build_type> does not default to catkin if a false condition is present #1170
Comments
For the record, the error that happens is:
|
I think the root cause is in |
IIUC, this code block here should be updated to use get_build_type(). Contributions are welcomed, feel free to tag me as a reviewer. |
This issue has been mentioned on ROS Discourse. There might be relevant details there: |
To reproduce: add the line
<build_type condition="$ROS_VERSION == 2">ament_cmake</build_type>
to a ROS1 package like stereo_msgs.catkin_make_isolated
will fail now.Expected behavior: The complete line should be ignored because of the condition and the default of
catkin
should be used.Interesting detail: This works:
And this doesn't:
The text was updated successfully, but these errors were encountered: