Problem with rpath in qt_gui_cpp_sip

[mpflanzer]

Forcing the rpath to the devel space is causing problems when the packages are used from the install space. Especially on macOS this is a problem since DYLD_LIBRARY_PATH is no longer searched since SIP is enabled. Hence, having a correct rpath is essential.

qt_gui_core/qt_gui_cpp/src/qt_gui_cpp_sip/CMakeLists.txt

Lines 32 to 33 in 2333cb0

	set(qt_gui_cpp_sip_LIBRARY_DIRS ${qt_gui_cpp_LIBRARY_DIRS} ${CATKIN_DEVEL_PREFIX}/lib)
	set(qt_gui_cpp_sip_LDFLAGS_OTHER ${qt_gui_cpp_LDFLAGS_OTHER} -Wl,-rpath,\\"${CATKIN_DEVEL_PREFIX}/lib\\")

Instead of hard coding the rpath value the cmake RPATH options should be respected: https://cmake.org/Wiki/CMake_RPATH_handling
I guess, ideally the qt_gui_cpp_sip target would be installed via the cmake install command which should take care of setting the correct RPATH.

[dirk-thomas]

Please consider proving a patch for this.