Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: option to skip installation of DDS packages #268

Open
scpeters opened this issue Sep 10, 2020 · 0 comments
Open

Feature request: option to skip installation of DDS packages #268

scpeters opened this issue Sep 10, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@scpeters
Copy link

Description

This is a very useful action step for setting up a workflow that compiles packages in a colcon workspace. Since colcon is a tool that can be used in non-ROS contexts, I wanted to see if there is interest in using this action without installing DDS packages.

cc @stonier

Related Issues

N/A

Completion Criteria

Add a parameter for skipping installation of DDS packages.

Implementation Notes / Suggestions

It looks like the logic for installing DDS implementations is intermingled with the logic for installing compilers and development tools in the package_manager/apt.ts file.

DDS-specific lines:

Perhaps the DDS-specific lines could be split into a separate file to more easily enable or disable the DDS packages.

Testing Notes / Suggestions

Test a typical ROS workflow with DDS installed and a workflow without DDS installed and confirm that the setup time is reduced without the extra packages.

@scpeters scpeters added the enhancement New feature or request label Sep 10, 2020
@emersonknapp emersonknapp added enhancement New feature or request and removed enhancement New feature or request labels Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants