tag_status should be set to inactive once ROS_DISTRO is deprecated

[flynneva]

Description

In order to automate some CI a bit it would be awesome if the docker tag itself could hold information on if the distro is active or inactive. Maybe it already does this somewhere but I just dont know about it yet?

I see tag_status and status in the json from here:

https://hub.docker.com/v2/repositories/rostooling/setup-ros-docker/tags?page_size=1000"

Related Issues

Not that I could find

Completion Criteria

• some way included in the image json to tell when a distro is inactive

Implementation Notes / Suggestions

• maybe add a new element called distro_status or something? That way it shouldnt disrupt any existing code

Testing Notes / Suggestions

** All features in this project need tests. Please give some input on cases that will need to be tested - and how the testing might be implemented. **

[christophebedard]

I am not the original author, but I don't think we explicitly set tag_status or status. I'm guessing we can set more of these through the labels option of https://github.com/docker/build-push-action

The thing is that (I think) we stop building images for distros once they're end-of-life, so we'd need to build them one last time to set the right distro_status value?

[flynneva]

@christophebedard oops thanks for transferring this issue to the right repo.

Yes you are right - I think in order to implement this you'd have to build "one last time"....unless you're able to edit the meta-info of a docker image after the initial build. I'm not a docker expert so I don't know if this is possible or not.

[flynneva]

For reference, this is the PR that lead me to create this issue:

flynneva/usb_cam#2

You can check out the workflow that I'm working on there. Within it there is a script that we could use to filter active distros "if" this issue was implemented.

[christophebedard]

What if you got the "active/not active" information from somewhere else? Like another action, or a simple web page/static link? You could do this by looking at the distro snapshots and seeing which distro has a final snapshot: http://snapshots.ros.org/

This way you could use it for other things, not just these Docker images.

[flynneva]

@christophebedard thats a great suggestion! I'll try out parsing that snapshot site in a simple script once I find some time. Thanks for the tip!

[flynneva]

@christophebedard I finally find some time to get back to this and have written a small script to list active distros based on the snapshot site:

https://github.com/flynneva/active_ros_distros/issues

The only issue is that Iron doesn't seem to be listed yet on the snapshot site.

Any ideas how we can add iron to the snapshot site?

EDIT: I just asked the question on ROS discourse so we'll hopefully see an answer there

[christophebedard]

Not sure why Iron isn't included. Hopefully the snapshots website gets updated properly/frequently.

[clalancette]

@nuclearsandwich can you comment about the snapshots repo?