Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colcon-* versions #42

Closed

Conversation

kenji-miyake
Copy link

Resolves #41

Signed-off-by: Kenji Miyake <[email protected]>
@kenji-miyake kenji-miyake requested a review from a team as a code owner August 16, 2021 09:14
@kenji-miyake kenji-miyake requested review from emersonknapp and christophebedard and removed request for a team August 16, 2021 09:14
@christophebedard
Copy link
Member

This looks good to me, but since there's no tagging/versioning for these images, it means that, if someone is using an older version of action-ros-ci, their CI might start failing like ros-tooling/action-ros-ci#615. I think we could just update everything but keep colcon-mixin to <0.1.10 in order to avoid failures like that and then figure out what to do about colcon-mixin afterwards.

Signed-off-by: Kenji Miyake <[email protected]>
@kenji-miyake
Copy link
Author

@christophebedard I'm sorry, I forgot to change as you suggested. Now it's done.
Also, as for the versioning, do you have any plan for that?

@christophebedard
Copy link
Member

christophebedard commented Aug 24, 2021

@christophebedard I'm sorry, I forgot to change as you suggested. Now it's done.

Thanks! Were you able to test it with action-ros-ci @ v0.2? It might also be a good idea to test it with v0.1 just to make sure it works and doesn't cause a regression.

Also, as for the versioning, do you have any plan for that?

I would let @emersonknapp answer this.

@kenji-miyake
Copy link
Author

@christophebedard

Were you able to test it with action-ros-ci @ v0.2?

Not yet.
How can I test with the Docker image that will be created in this PR? 🤔
I guess Docker images won't be published from PRs.

@christophebedard
Copy link
Member

How can I test with the Docker image that will be created in this PR?
I guess Docker images won't be published from PRs.

You can probably modify the workflow config on your fork and get it to build the image on a branch other than master. Then you can use the image from your fork (like kenji-miyake/setup-ros-docker:...).

@kenji-miyake
Copy link
Author

@christophebedard Okay, I'll try it!

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion on tracking issue - adding my review to clear it from my queue for now

@emersonknapp
Copy link
Contributor

Closing as stale for now - please open new PR if change will be worked on in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

colcon-package-selection is old
3 participants